Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2332213010: [DevTools] Fix out of process iframes not working on chrome://inspect. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix out of process iframes not working on chrome://inspect. Regressed in recent refactoring of devtools discovery. Added checks to existing tests. BUG=627517 Committed: https://crrev.com/dda2ff1de0b3ca84fda1e92c196d57c66b7d5779 Cr-Commit-Position: refs/heads/master@{#419030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/devtools/site_per_process_devtools_browsertest.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-09-15 22:09:09 UTC) #2
pfeldman
lgtm
4 years, 3 months ago (2016-09-15 22:12:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332213010/1
4 years, 3 months ago (2016-09-15 22:14:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 23:10:44 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 23:14:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dda2ff1de0b3ca84fda1e92c196d57c66b7d5779
Cr-Commit-Position: refs/heads/master@{#419030}

Powered by Google App Engine
This is Rietveld 408576698