Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: content/browser/devtools/site_per_process_devtools_browsertest.cc

Issue 2332213010: [DevTools] Fix out of process iframes not working on chrome://inspect. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/site_per_process_devtools_browsertest.cc
diff --git a/content/browser/devtools/site_per_process_devtools_browsertest.cc b/content/browser/devtools/site_per_process_devtools_browsertest.cc
index 74f4adb82e322b83279c1bb33668c77ee2092ebf..c729ee5561e03a096105d1e6b88cbc8dd9ed8157 100644
--- a/content/browser/devtools/site_per_process_devtools_browsertest.cc
+++ b/content/browser/devtools/site_per_process_devtools_browsertest.cc
@@ -100,6 +100,9 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
EXPECT_EQ(main_url.spec(), list[0]->GetURL().spec());
EXPECT_EQ(DevToolsAgentHost::kTypePage, list[1]->GetType());
EXPECT_EQ(cross_site_url.spec(), list[1]->GetURL().spec());
+ EXPECT_EQ(std::string(), list[0]->GetParentId());
+ EXPECT_EQ(list[0]->GetId(), list[1]->GetParentId());
+ EXPECT_NE(list[1]->GetId(), list[0]->GetId());
// Attaching to both agent hosts.
scoped_refptr<DevToolsAgentHost> child_host = list[1];
@@ -167,6 +170,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest, AgentHostForFrames) {
child_frame_agent =
DevToolsAgentHost::GetOrCreateFor(child->current_frame_host());
EXPECT_NE(page_agent.get(), child_frame_agent.get());
+ EXPECT_EQ(child_frame_agent->GetParentId(), page_agent->GetId());
+ EXPECT_NE(child_frame_agent->GetId(), page_agent->GetId());
}
IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
@@ -194,6 +199,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
scoped_refptr<DevToolsAgentHost> main_frame_agent =
DevToolsAgentHost::GetOrCreateFor(root->current_frame_host());
EXPECT_NE(main_frame_agent.get(), child_frame_agent.get());
+ EXPECT_EQ(child_frame_agent->GetParentId(), main_frame_agent->GetId());
+ EXPECT_NE(child_frame_agent->GetId(), main_frame_agent->GetId());
// Agent for web contents should be the the main frame's one.
scoped_refptr<DevToolsAgentHost> page_agent =
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698