JobController3: Move MarkAlternativeServiceBroken to job controller

net/http/http_stream_factory_impl_job.h

Index: net/http/http_stream_factory_impl_job.h
diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h
index 492b8082167e0781f472927cb0ceaf7ee2cce7cc..98a0f089ceaedd5592abd02481a044dad278d056 100644
--- a/net/http/http_stream_factory_impl_job.h
+++ b/net/http/http_stream_factory_impl_job.h
@@ -48,6 +48,12 @@ class HttpStreamFactoryImpl::Job {
    public:
     virtual ~Delegate() {}
 
+    // Invoked when |job| has alternative service identified borken.

[Ryan Hamilton, 2016/09/13 04:17:04]

s/borken/broken/ (and below)

[Zhongyi Shi, 2016/09/13 22:52:37]

Done.

+    virtual void OnAlternativeServiceBroken(Job* job) = 0;
+
+    // Invoked when |job| has alternative proxy server identified borken.
+    virtual void OnAlternativeProxyServerBroken(Job* job) = 0;
+
     // Invoked when |job| has an HttpStream ready.
     virtual void OnStreamReady(Job* job,
                                const SSLConfig& used_ssl_config,
@@ -235,11 +241,15 @@ class HttpStreamFactoryImpl::Job {
   // will be orphaned.
   void ReportJobSucceededForRequest();
 
-  // Marks that the other |job| has completed.
-  virtual void MarkOtherJobComplete(const Job& job);
-
   JobType job_type() const { return job_type_; }
 
+  const AlternativeService alternative_service() {

[tbansal1, 2016/09/13 05:06:45]

Can this method be a const method? Same below.

[Zhongyi Shi, 2016/09/13 22:52:37]

Done.

+    return alternative_service_;
+  }
+  const ProxyServer alternative_proxy_server() {
+    return alternative_proxy_server_;
+  }
+
  private:
   friend class HttpStreamFactoryImplJobPeer;
 
@@ -380,13 +390,6 @@ class HttpStreamFactoryImpl::Job {
   // Should we force QUIC for this stream request.
   bool ShouldForceQuic() const;
 
-  void MaybeMarkAlternativeServiceBroken();
-
-  // May notify proxy delegate that the alternative proxy server is broken. The
-  // alternative proxy server is considered as broken if the alternative proxy
-  // server job failed, but the main job was successful.
-  void MaybeNotifyAlternativeProxyServerBroken() const;
-
   ClientSocketPoolManager::SocketGroupType GetSocketGroup() const;
 
   void MaybeCopyConnectionAttemptsFromSocketOrHandle();