JobController3: Move MarkAlternativeServiceBroken to job controller

net/http/http_stream_factory_impl_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_
 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 30 matching lines @@
 
 // An HttpStreamRequestImpl exists for each stream which is in progress of being
 // created for the StreamFactory.
 class HttpStreamFactoryImpl::Job {
  public:
   // Delegate to report Job's status to Request and HttpStreamFactory.
   class NET_EXPORT_PRIVATE Delegate {
    public:
     virtual ~Delegate() {}
 
+    // Invoked when |job| has alternative service identified borken.

[Ryan Hamilton, 2016/09/13 04:17:04]

s/borken/broken/ (and below)

[Zhongyi Shi, 2016/09/13 22:52:37]

Done.

+    virtual void OnAlternativeServiceBroken(Job* job) = 0;
+
+    // Invoked when |job| has alternative proxy server identified borken.
+    virtual void OnAlternativeProxyServerBroken(Job* job) = 0;
+
     // Invoked when |job| has an HttpStream ready.
     virtual void OnStreamReady(Job* job,
                                const SSLConfig& used_ssl_config,
                                const ProxyInfo& used_proxy_info) = 0;
 
     // Invoked when |job| has a BidirectionalStream ready.
     virtual void OnBidirectionalStreamImplReady(
         Job* job,
         const SSLConfig& used_ssl_config,
         const ProxyInfo& used_proxy_info) = 0;
@@ skipping 167 matching lines @@
 
   bool is_waiting() const { return next_state_ == STATE_WAIT_COMPLETE; }
   const SSLConfig& server_ssl_config() const;
   const SSLConfig& proxy_ssl_config() const;
   const ProxyInfo& proxy_info() const;
 
   // Called to indicate that this job succeeded, and some other jobs
   // will be orphaned.
   void ReportJobSucceededForRequest();
 
-  // Marks that the other |job| has completed.
-  virtual void MarkOtherJobComplete(const Job& job);
+  JobType job_type() const { return job_type_; }
 
-  JobType job_type() const { return job_type_; }
+  const AlternativeService alternative_service() {

[tbansal1, 2016/09/13 05:06:45]

Can this method be a const method? Same below.

[Zhongyi Shi, 2016/09/13 22:52:37]

Done.

+    return alternative_service_;
+  }
+  const ProxyServer alternative_proxy_server() {
+    return alternative_proxy_server_;
+  }
 
  private:
   friend class HttpStreamFactoryImplJobPeer;
 
   enum State {
     STATE_START,
     STATE_RESOLVE_PROXY,
     STATE_RESOLVE_PROXY_COMPLETE,
 
     // Note that when Alternate-Protocol says we can connect to an alternate
@@ skipping 121 matching lines @@
 
   // Called to handle a client certificate request.
   int HandleCertificateRequest(int error);
 
   // Moves this stream request into SPDY mode.
   void SwitchToSpdyMode();
 
   // Should we force QUIC for this stream request.
   bool ShouldForceQuic() const;
 
-  void MaybeMarkAlternativeServiceBroken();
-
-  // May notify proxy delegate that the alternative proxy server is broken. The
-  // alternative proxy server is considered as broken if the alternative proxy
-  // server job failed, but the main job was successful.
-  void MaybeNotifyAlternativeProxyServerBroken() const;
-
   ClientSocketPoolManager::SocketGroupType GetSocketGroup() const;
 
   void MaybeCopyConnectionAttemptsFromSocketOrHandle();
 
   // Record histograms of latency until Connect() completes.
   static void LogHttpConnectedMetrics(const ClientSocketHandle& handle);
 
   // Invoked by the transport socket pool after host resolution is complete
   // to allow the connection to be aborted, if a matching SPDY session can
   // be found.  Will return ERR_SPDY_SESSION_ALREADY_EXISTS if such a
@@ skipping 147 matching lines @@
       const SSLConfig& server_ssl_config,
       const SSLConfig& proxy_ssl_config,
       HostPortPair destination,
       GURL origin_url,
       NetLog* net_log) = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_