cheets: remove setWallpaper from ArcIntentHelper.

components/arc/common/intent_helper.mojom

Index: components/arc/common/intent_helper.mojom
diff --git a/components/arc/common/intent_helper.mojom b/components/arc/common/intent_helper.mojom
index 075721d9c72b78ef317f21aac8c7987703eb2aeb..46eb1386395bc1736f6672d6f7bc35c0d14231e6 100644
--- a/components/arc/common/intent_helper.mojom
+++ b/components/arc/common/intent_helper.mojom
@@ -88,10 +88,6 @@ interface IntentHelperHost {
 
   // Opens the wallpaper picker dialog.
   [MinVersion=6] OpenWallpaperPicker@3();
-
-  // Sets an image as the wallpaper.
-  // |jpeg_data| is a JPEG encoded wallpaper image.
-  [MinVersion=8] SetWallpaper@4(array<uint8> jpeg_data);

[Yusuke Sato, 2016/09/12 23:41:02]

Removing the interface right after the canary builder picks up your Android CL
sounds a bit scary to me still. For example, ARC++ will suddenly start crashing
if someone (ARC constable etc.) reverts your Android CL for whatever reason
after this Chromium CL is landed.

I thought the convention is to add "Deprecated" suffix to a method while keeping
the @N number the same (so SetWallpaperDeprecated@4 in this case) and change the
implementation to something like:

 void ...Bridge::...Deprecared(...) {
    LOG(ERROR) << "....";
 }

This way, we can at least avoid crashes even if someone revert your Android CL
later. WDYT?

Luis: do we have any guideline on this?

[Muyuan, 2016/09/13 23:16:09]

Acknowledged.

 };
 
 // Sends intents to ARC on behalf of Chrome.