cheets: remove setWallpaper from ArcIntentHelper.

components/arc/common/intent_helper.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.

[Yusuke Sato, 2016/09/12 23:41:02]

Please also update the mojom file in the Android tree once you land this.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Next MinVersion: 11
 
 module arc.mojom;
 
 import "scale_factor.mojom";
 
 // Describes the type of action to invoke.
@@ skipping 69 matching lines @@
   [MinVersion=9] OnIntentFiltersUpdated@5(array<IntentFilter> intent_filters);
 
   // Opens the downloads directory in the Chrome OS file manager.
   [MinVersion=5] OnOpenDownloads@2();
 
   // Opens the url with Chrome for Chrome OS.
   OnOpenUrl@0(string url);
 
   // Opens the wallpaper picker dialog.
   [MinVersion=6] OpenWallpaperPicker@3();
-
-  // Sets an image as the wallpaper.
-  // |jpeg_data| is a JPEG encoded wallpaper image.
-  [MinVersion=8] SetWallpaper@4(array<uint8> jpeg_data);

[Yusuke Sato, 2016/09/12 23:41:02]

Removing the interface right after the canary builder picks up your Android CL
sounds a bit scary to me still. For example, ARC++ will suddenly start crashing
if someone (ARC constable etc.) reverts your Android CL for whatever reason
after this Chromium CL is landed.

I thought the convention is to add "Deprecated" suffix to a method while keeping
the @N number the same (so SetWallpaperDeprecated@4 in this case) and change the
implementation to something like:

 void ...Bridge::...Deprecared(...) {
    LOG(ERROR) << "....";
 }

This way, we can at least avoid crashes even if someone revert your Android CL
later. WDYT?

Luis: do we have any guideline on this?

[Muyuan, 2016/09/13 23:16:09]

Acknowledged.

 };
 
 // Sends intents to ARC on behalf of Chrome.
 // Next method ID: 9
 interface IntentHelperInstance {
 
   // Sets the given package as a preferred package. The next time an ACTION_VIEW
   // intent is sent with a URL that requires disambiguation, instead of opening
   // the ResolverActivity, this package will be picked if it is on the list.
   // When multiple packages are set as preferred, the most recent setting wins.
@@ skipping 34 matching lines @@
   // specified.  Data can be sent as extras by including a JSON map string which
   // will be automatically converted to a bundle accessible by the receiver.
   //
   // Note: Broadcasts can only be sent to whitelisted packages.  Packages can be
   // added to the whitelist in ArcBridgeService.java in the Android source.
   [MinVersion=1] SendBroadcast@1(string action,
                                  string package_name,
                                  string cls,
                                  string extras);
 };