cheets: remove setWallpaper from ArcIntentHelper.

cheets: deprecate setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
Committed: https://crrev.com/0b7b15bafeb502cdaef5744f66426a341463f18e
Cr-Commit-Position: refs/heads/master@{#419015}

[Muyuan, 2016-09-12 21:53:36]

muyuanli@chromium.org changed reviewers:
+ lhchavez@chromium.org, yusukes@chromium.org

[Luis Héctor Chávez, 2016-09-12 21:57:22]

https://codereview.chromium.org/2332063004/diff/1/components/arc/intent_helpe...
File components/arc/intent_helper/arc_intent_helper_bridge.cc (left):

https://codereview.chromium.org/2332063004/diff/1/components/arc/intent_helpe...
components/arc/intent_helper/arc_intent_helper_bridge.cc:12: #include
"ash/common/wallpaper/wallpaper_delegate.h"
This looks unused now.

[Muyuan, 2016-09-12 22:05:44]

https://codereview.chromium.org/2332063004/diff/1/components/arc/intent_helpe...
File components/arc/intent_helper/arc_intent_helper_bridge.cc (left):

https://codereview.chromium.org/2332063004/diff/1/components/arc/intent_helpe...
components/arc/intent_helper/arc_intent_helper_bridge.cc:12: #include
"ash/common/wallpaper/wallpaper_delegate.h"
On 2016/09/12 21:57:22, Luis Héctor Chávez wrote:
> This looks unused now.

It seems to be used to open wallpaper picker page:

https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_...

[Yusuke Sato, 2016-09-12 23:41:02]

https://codereview.chromium.org/2332063004/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (left):

https://codereview.chromium.org/2332063004/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:94: [MinVersion=8]
SetWallpaper@4(array<uint8> jpeg_data);
Removing the interface right after the canary builder picks up your Android CL
sounds a bit scary to me still. For example, ARC++ will suddenly start crashing
if someone (ARC constable etc.) reverts your Android CL for whatever reason
after this Chromium CL is landed.

I thought the convention is to add "Deprecated" suffix to a method while keeping
the @N number the same (so SetWallpaperDeprecated@4 in this case) and change the
implementation to something like:

 void ...Bridge::...Deprecared(...) {
    LOG(ERROR) << "....";
 }

This way, we can at least avoid crashes even if someone revert your Android CL
later. WDYT?

Luis: do we have any guideline on this?

https://codereview.chromium.org/2332063004/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2332063004/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
Please also update the mojom file in the Android tree once you land this.

[Muyuan, 2016-09-13 23:16:09]

https://codereview.chromium.org/2332063004/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (left):

https://codereview.chromium.org/2332063004/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:94: [MinVersion=8]
SetWallpaper@4(array<uint8> jpeg_data);
On 2016/09/12 23:41:02, Yusuke Sato wrote:
> Removing the interface right after the canary builder picks up your Android CL
> sounds a bit scary to me still. For example, ARC++ will suddenly start
crashing
> if someone (ARC constable etc.) reverts your Android CL for whatever reason
> after this Chromium CL is landed.
> 
> I thought the convention is to add "Deprecated" suffix to a method while
keeping
> the @N number the same (so SetWallpaperDeprecated@4 in this case) and change
the
> implementation to something like:
> 
>  void ...Bridge::...Deprecared(...) {
>     LOG(ERROR) << "....";
>  }
> 
> This way, we can at least avoid crashes even if someone revert your Android CL
> later. WDYT?
> 
> Luis: do we have any guideline on this?

Acknowledged.

[Yusuke Sato, 2016-09-13 23:19:29]

thanks, lgtm, defer to Luis. Please also update the CL description
(s/remove/deprecate/g).

https://codereview.chromium.org/2332063004/diff/20001/components/arc/common/i...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2332063004/diff/20001/components/arc/common/i...
components/arc/common/intent_helper.mojom:74: // Next method ID: 6
Please add

 // Deprecated method ID: 4

between line 73 and 74.

[Muyuan, 2016-09-14 00:12:34]

Description was changed from

==========
cheets: remove setWallpaper from ArcIntentHelper.

This CL removes setWallpaper call from ArcIntentHelper
and correspondingly, intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Commit=false
Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
==========

to

==========
cheets: remove setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Commit=false
Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
==========

[Muyuan, 2016-09-14 00:13:02]

https://codereview.chromium.org/2332063004/diff/20001/components/arc/common/i...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2332063004/diff/20001/components/arc/common/i...
components/arc/common/intent_helper.mojom:74: // Next method ID: 6
On 2016/09/13 23:19:28, Yusuke Sato wrote:
> Please add
> 
>  // Deprecated method ID: 4
> 
> between line 73 and 74.

Done.

[Yusuke Sato, 2016-09-15 14:11:59]

lgtm

[Luis Héctor Chávez, 2016-09-15 16:02:24]

lgtm

[Muyuan, 2016-09-15 17:51:16]

Description was changed from

==========
cheets: remove setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Commit=false
Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
==========

to

==========
cheets: deprecate setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
==========

[Muyuan, 2016-09-15 17:51:21]

The CQ bit was checked by muyuanli@chromium.org

[commit-bot: I haz the power, 2016-09-15 17:51:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:00:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yusuke Sato, 2016-09-15 18:02:13]

ah, rickyz@'s review for mojom is also necessary.

[Yusuke Sato, 2016-09-15 18:02:48]

yusukes@chromium.org changed reviewers:
+ rickyz@chromium.org

[Yusuke Sato, 2016-09-15 18:02:49]

+Ricky

[rickyz (no longer on Chrome), 2016-09-15 22:05:20]

lgtm

[Muyuan, 2016-09-15 22:12:43]

Correspoonding Android change has landed ToT with ARC build #3265915 and
#3271145.

[Muyuan, 2016-09-15 22:12:51]

The CQ bit was checked by muyuanli@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:13:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:27:05]

Description was changed from

==========
cheets: deprecate setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
==========

to

==========
cheets: deprecate setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
==========

[commit-bot: I haz the power, 2016-09-15 22:27:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 22:29:27]

Description was changed from

==========
cheets: deprecate setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465
==========

to

==========
cheets: deprecate setWallpaper from ArcIntentHelper.

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465

Committed: https://crrev.com/0b7b15bafeb502cdaef5744f66426a341463f18e
Cr-Commit-Position: refs/heads/master@{#419015}
==========

[commit-bot: I haz the power, 2016-09-15 22:29:28]

Patchset 3 (id:??) landed as
https://crrev.com/0b7b15bafeb502cdaef5744f66426a341463f18e
Cr-Commit-Position: refs/heads/master@{#419015}