Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject, LayoutFlexibleObject, LayoutGrid, LayoutObject, LayoutObjectChildList.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7a5a65d12fdb71cba72df34881548cfaaf6b618c
Cr-Commit-Position: refs/heads/master@{#418196}

[krasin1, 2016-09-12 18:43:56]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[krasin1, 2016-09-12 18:44:43]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject, LayoutFlexibleObject, LayoutGrid, LayoutObject,
LayoutObjectChildList.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[krasin1, 2016-09-12 18:46:03]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 18:46:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-09-12 19:24:04]

krasin@chromium.org changed reviewers:
+ eae@chromium.org

[krasin1, 2016-09-12 19:24:05]

Hi Emil,

this is yet another boring CL that converts tools/cfi/blacklist.txt into the
attributes. With this change in, we'll be at 75% blacklist converted.

[eae, 2016-09-12 19:25:28]

LGTM

Feel free to TBR changes like this to me and I'll review them post-facto.

[eae, 2016-09-12 19:25:30]

LGTM

Feel free to TBR changes like this to me and I'll review them post-facto.

[krasin1, 2016-09-12 19:41:46]

On 2016/09/12 19:25:30, eae wrote:
> LGTM
> 
> Feel free to TBR changes like this to me and I'll review them post-facto.

Ack, thanks. That will be useful, when I start removing the attributes.

[krasin1, 2016-09-12 19:41:56]

The CQ bit was unchecked by krasin@chromium.org

[krasin1, 2016-09-12 19:42:03]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-09-12 19:42:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:10:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[krasin1, 2016-09-13 05:41:03]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-09-13 05:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 08:29:07]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject, LayoutFlexibleObject, LayoutGrid, LayoutObject,
LayoutObjectChildList.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject, LayoutFlexibleObject, LayoutGrid, LayoutObject,
LayoutObjectChildList.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-13 08:29:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 08:30:51]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject, LayoutFlexibleObject, LayoutGrid, LayoutObject,
LayoutObjectChildList.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlockModelObject, LayoutFlexibleObject, LayoutGrid, LayoutObject,
LayoutObjectChildList.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7a5a65d12fdb71cba72df34881548cfaaf6b618c
Cr-Commit-Position: refs/heads/master@{#418196}
==========

[commit-bot: I haz the power, 2016-09-13 08:30:52]

Patchset 4 (id:??) landed as
https://crrev.com/7a5a65d12fdb71cba72df34881548cfaaf6b618c
Cr-Commit-Position: refs/heads/master@{#418196}