Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2332053002: Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled. (Closed)
Patch Set: LayoutObject, LayoutObjectChildList Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 if (hasLayer() && diff.needsPaintInvalidationSubtree()) { 225 if (hasLayer() && diff.needsPaintInvalidationSubtree()) {
226 if (oldStyle->hasAutoClip() != newStyle.hasAutoClip() 226 if (oldStyle->hasAutoClip() != newStyle.hasAutoClip()
227 || oldStyle->clip() != newStyle.clip()) 227 || oldStyle->clip() != newStyle.clip())
228 layer()->clipper().clearClipRectsIncludingDescendants(); 228 layer()->clipper().clearClipRectsIncludingDescendants();
229 } 229 }
230 } 230 }
231 231
232 LayoutObject::styleWillChange(diff, newStyle); 232 LayoutObject::styleWillChange(diff, newStyle);
233 } 233 }
234 234
235 DISABLE_CFI_PERF
235 void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt yle* oldStyle) 236 void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt yle* oldStyle)
236 { 237 {
237 bool hadTransform = hasTransformRelatedProperty(); 238 bool hadTransform = hasTransformRelatedProperty();
238 bool hadLayer = hasLayer(); 239 bool hadLayer = hasLayer();
239 bool layerWasSelfPainting = hadLayer && layer()->isSelfPaintingLayer(); 240 bool layerWasSelfPainting = hadLayer && layer()->isSelfPaintingLayer();
240 bool wasFloatingBeforeStyleChanged = FloatStateForStyleChange::wasFloating(t his); 241 bool wasFloatingBeforeStyleChanged = FloatStateForStyleChange::wasFloating(t his);
241 bool wasHorizontalWritingMode = isHorizontalWritingMode(); 242 bool wasHorizontalWritingMode = isHorizontalWritingMode();
242 243
243 LayoutObject::styleDidChange(diff, oldStyle); 244 LayoutObject::styleDidChange(diff, oldStyle);
244 updateFromStyle(); 245 updateFromStyle();
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 { 431 {
431 if (TransformOperation* translate = style.translate()) { 432 if (TransformOperation* translate = style.translate()) {
432 if (translate->dependsOnBoxSize()) 433 if (translate->dependsOnBoxSize())
433 return true; 434 return true;
434 } 435 }
435 return style.transform().dependsOnBoxSize() 436 return style.transform().dependsOnBoxSize()
436 || (style.transformOriginX() != Length(50, Percent) && style.transformOr iginX().isPercentOrCalc()) 437 || (style.transformOriginX() != Length(50, Percent) && style.transformOr iginX().isPercentOrCalc())
437 || (style.transformOriginY() != Length(50, Percent) && style.transformOr iginY().isPercentOrCalc()); 438 || (style.transformOriginY() != Length(50, Percent) && style.transformOr iginY().isPercentOrCalc());
438 } 439 }
439 440
441 DISABLE_CFI_PERF
440 void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState) 442 void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)
441 { 443 {
442 ensureIsReadyForPaintInvalidation(); 444 ensureIsReadyForPaintInvalidation();
443 445
444 PaintInvalidationState newPaintInvalidationState(paintInvalidationState, *th is); 446 PaintInvalidationState newPaintInvalidationState(paintInvalidationState, *th is);
445 if (!shouldCheckForPaintInvalidation(newPaintInvalidationState)) 447 if (!shouldCheckForPaintInvalidation(newPaintInvalidationState))
446 return; 448 return;
447 449
448 if (mayNeedPaintInvalidationSubtree()) 450 if (mayNeedPaintInvalidationSubtree())
449 newPaintInvalidationState.setForceSubtreeInvalidationCheckingWithinConta iner(); 451 newPaintInvalidationState.setForceSubtreeInvalidationCheckingWithinConta iner();
(...skipping 720 matching lines...) Expand 10 before | Expand all | Expand 10 after
1170 if (rootElementStyle->hasBackground()) 1172 if (rootElementStyle->hasBackground())
1171 return false; 1173 return false;
1172 1174
1173 if (node() != document().firstBodyElement()) 1175 if (node() != document().firstBodyElement())
1174 return false; 1176 return false;
1175 1177
1176 return true; 1178 return true;
1177 } 1179 }
1178 1180
1179 } // namespace blink 1181 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698