Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2332023002: Correctly set requestor origin for worker initiated requests. (Closed)

Created:
4 years, 3 months ago by jsbell
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Correctly set requestor origin for worker initiated requests. ResourceRequest.requestTorOrigin() can never be null (since it is initialized to a unique origin rather than null). Because of that the check in FrameFetchContext::populateRequestData meant that this code would never actually set the requestor origin of a request. For requests from frames the code in RenderFrameImpl::willSendRequest would then replace the origin with the correct one anyway, but no such code exists for shared/service workers. BUG=645281, 625969 Review-Url: https://codereview.chromium.org/2323143002 Cr-Commit-Position: refs/heads/master@{#417712} (cherry picked from commit 65299f214fad8f609c5872bcdd5f4ea82ec29713) Committed: https://chromium.googlesource.com/chromium/src/+/3fa4d0dbbd3f3839ec00a64e5c711bc0f3658416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/foreign-fetch-worker.js View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jsbell
4 years, 3 months ago (2016-09-12 17:19:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fa4d0dbbd3f3839ec00a64e5c711bc0f3658416.

Powered by Google App Engine
This is Rietveld 408576698