Correctly set requestor origin for worker initiated requests.

Correctly set requestor origin for worker initiated requests.

ResourceRequest.requestTorOrigin() can never be null (since it is initialized
to a unique origin rather than null). Because of that the check in
FrameFetchContext::populateRequestData meant that this code would never
actually set the requestor origin of a request. For requests from frames the
code in RenderFrameImpl::willSendRequest would then replace the origin with
the correct one anyway, but no such code exists for shared/service workers.

BUG=645281, 625969
Committed: https://crrev.com/65299f214fad8f609c5872bcdd5f4ea82ec29713
Cr-Commit-Position: refs/heads/master@{#417712}

[Marijn Kruisselbrink, 2016-09-08 22:53:04]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 22:53:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2016-09-08 23:14:38]

mek@chromium.org changed reviewers:
+ japhet@chromium.org

[Marijn Kruisselbrink, 2016-09-08 23:14:38]

japhet: could you review this? mkwst is probably a more appropriate reviewer,
but he appears to be OOO

[Marijn Kruisselbrink, 2016-09-08 23:32:47]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 23:33:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 01:02:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 01:02:27]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-09-09 19:03:00]

lgtm. Overwriting a unique SecurityOrigin looks highly suspect, but it sounds
like that's what the TODO is addressed.

Can the render_frame_impl.cc usage be removed now? It seems like it's redundant
now.

[Marijn Kruisselbrink, 2016-09-09 19:05:15]

Description was changed from

==========
Correctly set requestor origin for worker initiated requests.

ResourceRequest.requestTorOrigin() can never be null (since it is initialized
to a unique origin rather than null). Because of that the check in
FrameFetchContext::populateRequestData meant that this code would never
actually set the requestor origin of a request. For requests from frames the
code in RenderFrameImpl::willSendRequest would then replace the origin with
the correct one anyway, but no such code exists for shared/service workers.

BUG=645281
==========

to

==========
Correctly set requestor origin for worker initiated requests.

ResourceRequest.requestTorOrigin() can never be null (since it is initialized
to a unique origin rather than null). Because of that the check in
FrameFetchContext::populateRequestData meant that this code would never
actually set the requestor origin of a request. For requests from frames the
code in RenderFrameImpl::willSendRequest would then replace the origin with
the correct one anyway, but no such code exists for shared/service workers.

BUG=645281,625969
==========

[Marijn Kruisselbrink, 2016-09-09 19:07:02]

On 2016/09/09 19:03:00, Nate Chapin wrote:
> lgtm. Overwriting a unique SecurityOrigin looks highly suspect, but it sounds
> like that's what the TODO is addressed.
> 
> Can the render_frame_impl.cc usage be removed now? It seems like it's
redundant
> now.

It probably can, but I'd rather let Mike figure that out himself.

[Marijn Kruisselbrink, 2016-09-09 19:07:08]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:07:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:13:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Marijn Kruisselbrink, 2016-09-09 19:32:26]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-09-09 19:32:26]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2323143002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-09 19:32:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 21:11:34]

Description was changed from

==========
Correctly set requestor origin for worker initiated requests.

ResourceRequest.requestTorOrigin() can never be null (since it is initialized
to a unique origin rather than null). Because of that the check in
FrameFetchContext::populateRequestData meant that this code would never
actually set the requestor origin of a request. For requests from frames the
code in RenderFrameImpl::willSendRequest would then replace the origin with
the correct one anyway, but no such code exists for shared/service workers.

BUG=645281,625969
==========

to

==========
Correctly set requestor origin for worker initiated requests.

ResourceRequest.requestTorOrigin() can never be null (since it is initialized
to a unique origin rather than null). Because of that the check in
FrameFetchContext::populateRequestData meant that this code would never
actually set the requestor origin of a request. For requests from frames the
code in RenderFrameImpl::willSendRequest would then replace the origin with
the correct one anyway, but no such code exists for shared/service workers.

BUG=645281,625969
==========

[commit-bot: I haz the power, 2016-09-09 21:11:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-09 21:12:48]

Description was changed from

==========
Correctly set requestor origin for worker initiated requests.

ResourceRequest.requestTorOrigin() can never be null (since it is initialized
to a unique origin rather than null). Because of that the check in
FrameFetchContext::populateRequestData meant that this code would never
actually set the requestor origin of a request. For requests from frames the
code in RenderFrameImpl::willSendRequest would then replace the origin with
the correct one anyway, but no such code exists for shared/service workers.

BUG=645281,625969
==========

to

==========
Correctly set requestor origin for worker initiated requests.

ResourceRequest.requestTorOrigin() can never be null (since it is initialized
to a unique origin rather than null). Because of that the check in
FrameFetchContext::populateRequestData meant that this code would never
actually set the requestor origin of a request. For requests from frames the
code in RenderFrameImpl::willSendRequest would then replace the origin with
the correct one anyway, but no such code exists for shared/service workers.

BUG=645281,625969

Committed: https://crrev.com/65299f214fad8f609c5872bcdd5f4ea82ec29713
Cr-Commit-Position: refs/heads/master@{#417712}
==========

[commit-bot: I haz the power, 2016-09-09 21:12:50]

Patchset 3 (id:??) landed as
https://crrev.com/65299f214fad8f609c5872bcdd5f4ea82ec29713
Cr-Commit-Position: refs/heads/master@{#417712}