Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2332003002: IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty (Closed)

Created:
2 years, 10 months ago by jsbell
Modified:
2 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty When converting arrays to keys, only own properties should be considered, much like clones. Otherwise, this opens up the behavior to side effects via getters on the Object/Array prototype even if the value being converted to a key is a clone. BUG=641101 R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2279343002 Cr-Commit-Position: refs/heads/master@{#415172} (cherry picked from commit 0438433a38d4e54190dadf356bd74ce76065a684) Committed: https://chromium.googlesource.com/chromium/src/+/99b38ec79374b0cb01ebd6801f9fdb56686bde6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/storage/indexeddb/bindings-edges.html View 5 chunks +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jsbell
2 years, 10 months ago (2016-09-12 16:30:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99b38ec79374b0cb01ebd6801f9fdb56686bde6b.

Powered by Google App Engine
This is Rietveld 408576698