IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org

Committed: https://crrev.com/0438433a38d4e54190dadf356bd74ce76065a684
Cr-Commit-Position: refs/heads/master@{#415172}

[jsbell, 2016-08-26 18:38:01]

haraken@ - please take a look?

Similar to crbug.com/637963 - code inspection indicates the other Get() calls
are always preceded by a HasOwnProperty check.

[haraken, 2016-08-27 00:31:40]

LGTM

[jsbell, 2016-08-29 16:21:11]

Description was changed from

==========
IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org
==========

to

==========
IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org
==========

[jsbell, 2016-08-29 16:21:17]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:22:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsansome, 2016-08-30 01:46:11]

The CQ bit was unchecked by dsansome@chromium.org

[dsansome, 2016-08-30 03:54:33]

dsansome@chromium.org changed reviewers:
+ dsansome@chromium.org

[dsansome, 2016-08-30 03:54:33]

(I unset the commit bit on this change to try fix a stuck CQ -
https://bugs.chromium.org/p/chromium/issues/detail?id=642077.  The issue is
fixed now so I'm sending this to CQ again for you)

[dsansome, 2016-08-30 03:55:29]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:57:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:42:27]

Description was changed from

==========
IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org
==========

to

==========
IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 05:42:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 05:45:20]

Description was changed from

==========
IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org
==========

to

==========
IndexedDB: Avoid side effects for array key conversion w/ HasOwnProperty

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org

Committed: https://crrev.com/0438433a38d4e54190dadf356bd74ce76065a684
Cr-Commit-Position: refs/heads/master@{#415172}
==========

[commit-bot: I haz the power, 2016-08-30 05:45:21]

Patchset 1 (id:??) landed as
https://crrev.com/0438433a38d4e54190dadf356bd74ce76065a684
Cr-Commit-Position: refs/heads/master@{#415172}