Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2331983002: cc: Make LayerTreeHost a protected Layer member. (Closed)

Created:
4 years, 3 months ago by Khushal
Modified:
4 years, 3 months ago
Reviewers:
Ian Vollick, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, jam, jbroman, Justin Novosad, Rik, darin-cc_chromium.org, pdr+graphicswatchlist_chromium.org, blink-reviews, f(malita), cc-bugs_chromium.org, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make LayerTreeHost a protected Layer member. Removes all external access to LayerTreeHost except for tests. Next change will remove it from Layer altogether. BUG=628683 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319 Cr-Commit-Position: refs/heads/master@{#418756}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : settings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -64 lines) Patch
M cc/layers/layer.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M cc/layers/layer_proto_converter_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/layer_unittest.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M cc/trees/layer_tree.cc View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_serialization.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_compositor_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (13 generated)
Khushal
+vollick for cc/ and Webkit/ +piman for content/
4 years, 3 months ago (2016-09-12 19:53:21 UTC) #8
piman
content/ lgtm
4 years, 3 months ago (2016-09-12 20:29:11 UTC) #9
Ian Vollick
On 2016/09/12 20:29:11, piman OOO back 2016-09-12 wrote: > content/ lgtm Seems straightforward. lgtm, too.
4 years, 3 months ago (2016-09-12 23:37:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331983002/20001
4 years, 3 months ago (2016-09-14 20:58:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/128702)
4 years, 3 months ago (2016-09-14 21:09:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331983002/40001
4 years, 3 months ago (2016-09-14 22:12:57 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 02:08:17 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 02:10:18 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319
Cr-Commit-Position: refs/heads/master@{#418756}

Powered by Google App Engine
This is Rietveld 408576698