Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2340143002: cc: Rename LayerTreeHost to LayerTreeHostInProcess. (Closed)

Created:
4 years, 3 months ago by Khushal
Modified:
4 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename LayerTreeHost to LayerTreeHostInProcess. This is the final patch in the series that abstracts the LayerTreeHost class to provide an implementation that run the impl thread components in-process (single-threaded and threaded compositor). This renames that existing implementation to the LayerTreeHostInProcess. Next up, we add an implementation that handles remoting the content provided to the compositor across a network boundary. BUG=625283 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/6156779859b6c4978df742a2a09426ef554c9861 Cr-Commit-Position: refs/heads/master@{#419338}

Patch Set 1 #

Patch Set 2 : tests + comment updates #

Total comments: 1

Patch Set 3 : content #

Patch Set 4 : missing include #

Patch Set 5 : rebase fun #

Patch Set 6 : blimp #

Patch Set 7 : blimp tests #

Patch Set 8 : content test #

Total comments: 2

Patch Set 9 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -1946 lines) Patch
M blimp/client/core/compositor/blimp_compositor.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/support/compositor/blimp_embedder_compositor.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/support/compositor/blimp_embedder_compositor.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/heads_up_display_layer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M cc/layers/picture_image_layer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 2 3 4 4 chunks +7 lines, -5 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 1 4 chunks +11 lines, -11 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 2 3 4 4 chunks +5 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/channel_main.h View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
M cc/trees/layer_tree.h View 3 chunks +20 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 3 4 1 chunk +178 lines, -365 lines 0 comments Download
D cc/trees/layer_tree_host.cc View 1 2 3 4 1 chunk +0 lines, -1044 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
A + cc/trees/layer_tree_host_in_process.h View 1 2 3 4 5 6 7 8 10 chunks +31 lines, -46 lines 0 comments Download
A + cc/trees/layer_tree_host_in_process.cc View 1 2 3 4 35 chunks +160 lines, -145 lines 0 comments Download
D cc/trees/layer_tree_host_interface.h View 1 2 3 4 1 chunk +0 lines, -190 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_remote_server.cc View 1 2 3 4 5 chunks +6 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/proxy_impl.h View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/proxy_main.h View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 1 2 3 4 5 chunks +10 lines, -10 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 2 3 4 5 chunks +9 lines, -8 lines 0 comments Download
M cc/trees/remote_channel_main.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/remote_channel_main.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M cc/trees/threaded_channel.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 3 chunks +7 lines, -5 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 45 (31 generated)
Khushal
Big rename patch is big. Since you suggested the name for this class, I figured ...
4 years, 3 months ago (2016-09-15 00:00:47 UTC) #3
Khushal
https://codereview.chromium.org/2340143002/diff/20001/cc/trees/layer_tree_host_in_process.h File cc/trees/layer_tree_host_in_process.h (right): https://codereview.chromium.org/2340143002/diff/20001/cc/trees/layer_tree_host_in_process.h#newcode99 cc/trees/layer_tree_host_in_process.h:99: static std::unique_ptr<LayerTreeHostInProcess> CreateThreaded( I made these return the in ...
4 years, 3 months ago (2016-09-15 00:56:20 UTC) #4
Khushal
friendly ping. Rebasing it once on the CompositorFrameSink patch was fun enough. :P
4 years, 3 months ago (2016-09-16 17:31:06 UTC) #25
Khushal
+enne for renderer compositor and Webkit +dtrainor for blimp +sievers for android UI compositor
4 years, 3 months ago (2016-09-16 18:08:14 UTC) #27
enne (OOO)
cc and render_widget_compositor lgtm I am not a Source/platform owner. +pdr https://codereview.chromium.org/2340143002/diff/140001/cc/trees/layer_tree_host_in_process.h File cc/trees/layer_tree_host_in_process.h (right): ...
4 years, 3 months ago (2016-09-16 18:19:42 UTC) #29
David Trainor- moved to gerrit
blimp/ lgtm
4 years, 3 months ago (2016-09-16 18:24:46 UTC) #30
pdr.
On 2016/09/16 at 18:24:46, dtrainor wrote: > blimp/ lgtm platform lgtm
4 years, 3 months ago (2016-09-16 18:31:47 UTC) #31
Khushal
+piman, may be you could take a look at rest of the content bits? Nothing ...
4 years, 3 months ago (2016-09-16 18:33:30 UTC) #33
Khushal
https://codereview.chromium.org/2340143002/diff/140001/cc/trees/layer_tree_host_in_process.h File cc/trees/layer_tree_host_in_process.h (right): https://codereview.chromium.org/2340143002/diff/140001/cc/trees/layer_tree_host_in_process.h#newcode339 cc/trees/layer_tree_host_in_process.h:339: // initialized a new output surface. |new_compositor_frame_sink_| contains the ...
4 years, 3 months ago (2016-09-16 18:38:40 UTC) #34
Khushal
On 2016/09/16 18:33:30, Khushal wrote: > +piman, may be you could take a look at ...
4 years, 3 months ago (2016-09-16 18:41:50 UTC) #35
piman
lgtm
4 years, 3 months ago (2016-09-16 20:41:12 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340143002/160001
4 years, 3 months ago (2016-09-16 20:42:13 UTC) #42
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 3 months ago (2016-09-17 00:14:17 UTC) #43
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 00:18:03 UTC) #45
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/6156779859b6c4978df742a2a09426ef554c9861
Cr-Commit-Position: refs/heads/master@{#419338}

Powered by Google App Engine
This is Rietveld 408576698