Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2331923002: Handle signature types and fields in kernel_impact (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle signature types and fields in kernel_impact R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/6e62b8af9a39b7ae02d88771b1c8b228bf20ecb0

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix lookup_map_test. #

Total comments: 4

Patch Set 4 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -35 lines) Patch
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 2 3 5 chunks +56 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/universe/feature.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years, 3 months ago (2016-09-12 10:00:13 UTC) #2
Johnni Winther
ping
4 years, 3 months ago (2016-09-13 08:12:21 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2331923002/diff/40001/pkg/compiler/lib/src/ssa/kernel_impact.dart File pkg/compiler/lib/src/ssa/kernel_impact.dart (right): https://codereview.chromium.org/2331923002/diff/40001/pkg/compiler/lib/src/ssa/kernel_impact.dart#newcode33 pkg/compiler/lib/src/ssa/kernel_impact.dart:33: print(kernel.functions); I am working on a change that ...
4 years, 3 months ago (2016-09-13 17:16:00 UTC) #4
Johnni Winther
Committed patchset #4 (id:60001) manually as 6e62b8af9a39b7ae02d88771b1c8b228bf20ecb0 (presubmit successful).
4 years, 3 months ago (2016-09-16 10:43:54 UTC) #6
Johnni Winther
4 years, 3 months ago (2016-09-16 10:46:10 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2331923002/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_impact.dart (right):

https://codereview.chromium.org/2331923002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_impact.dart:33: print(kernel.functions);
On 2016/09/13 17:15:59, Harry Terkelsen wrote:
> I am working on a change that will make kernel resolve a lot more things so
this
> map will be too big to print, consider removing

Done.

https://codereview.chromium.org/2331923002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_impact.dart:41: print(kernel.functions);
On 2016/09/13 17:15:59, Harry Terkelsen wrote:
> should be kernel.fields, or just remove

Done.

Powered by Google App Engine
This is Rietveld 408576698