pkg/compiler/lib/src/resolution/resolution.dart - Issue 2331923002: Handle signature types and fields in kernel_impact

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 2331923002: Handle signature types and fields in kernel_impact (Closed)

Patch Set: Updated cf. comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/resolution.dart

diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart

index 743ede2fde7aba34dcf82bb7ae1583b36536d7d1..37c0933c75f5d22c15a33b7dda844595e0f957f6 100644

--- a/pkg/compiler/lib/src/resolution/resolution.dart

+++ b/pkg/compiler/lib/src/resolution/resolution.dart

@@ -400,8 +400,7 @@ class ResolverTask extends CompilerTask {

reporter.reportErrorMessage(

element, MessageKind.FINAL_WITHOUT_INITIALIZER);

} else {

- // TODO(johnniwinther): Register a feature instead.

- registry.registerTypeUse(new TypeUse.instantiation(coreTypes.nullType));

+ registry.registerFeature(Feature.FIELD_WITHOUT_INITIALIZER);

}

if (Elements.isStaticOrTopLevelField(element)) {