Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2331913002: [interpreter] Use clearer names for context related functions. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Use clearer names for context related functions. R=rmcilroy@chromium.org BUG= Committed: https://crrev.com/153dde4f8602b1cb2fa4b76d17960df757a1a3e9 Cr-Commit-Position: refs/heads/master@{#39344}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move declaration down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/interpreter/bytecode-generator.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 9 chunks +10 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
neis
4 years, 3 months ago (2016-09-12 09:22:57 UTC) #1
rmcilroy
LGTM, thanks. https://codereview.chromium.org/2331913002/diff/1/src/interpreter/bytecode-generator.h File src/interpreter/bytecode-generator.h (right): https://codereview.chromium.org/2331913002/diff/1/src/interpreter/bytecode-generator.h#newcode128 src/interpreter/bytecode-generator.h:128: void VisitGeneratorPrologue(); nit - could you move ...
4 years, 3 months ago (2016-09-12 10:17:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331913002/20001
4 years, 3 months ago (2016-09-12 10:52:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 11:25:20 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 11:25:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/153dde4f8602b1cb2fa4b76d17960df757a1a3e9
Cr-Commit-Position: refs/heads/master@{#39344}

Powered by Google App Engine
This is Rietveld 408576698