Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2331003002: [modules] Make duplicate export error deterministic. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Make duplicate export error deterministic. In case of duplicate exports, always report the error for the very last one. R=adamk@chromium.org BUG=v8:5358, v8:1569 Committed: https://crrev.com/da1f911c4269048d24a3442791b18523455f3b24 Cr-Commit-Position: refs/heads/master@{#39424}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix logic bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M src/ast/modules.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast/modules.cc View 1 2 1 chunk +27 lines, -6 lines 0 comments Download
M test/message/export-duplicate.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/message/export-duplicate.out View 1 chunk +3 lines, -3 lines 0 comments Download
M test/message/export-duplicate-as.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/export-duplicate-as.out View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/export-duplicate-default.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/export-duplicate-default.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/message.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
neis
4 years, 3 months ago (2016-09-12 14:08:21 UTC) #1
neis
PTAL. It is probably preferable to report the first illegal entry but that would require ...
4 years, 3 months ago (2016-09-12 14:17:24 UTC) #2
adamk
lgtm
4 years, 3 months ago (2016-09-14 17:27:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331003002/20001
4 years, 3 months ago (2016-09-14 17:30:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 17:56:25 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/da1f911c4269048d24a3442791b18523455f3b24 Cr-Commit-Position: refs/heads/master@{#39424}
4 years, 3 months ago (2016-09-14 17:57:20 UTC) #8
Michael Hablich
4 years, 3 months ago (2016-09-14 21:51:31 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2340903002/ by hablich@chromium.org.

The reason for reverting is: Seems to break one of our arm64 bots:
https://chromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20-%20....

Powered by Google App Engine
This is Rietveld 408576698