Source/web/FrameLoaderClientImpl.cpp - Issue 23319002: Set MessageEvent.source to the newly created port for shared workers' connect events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 23319002: Set MessageEvent.source to the newly created port for shared workers' connect events (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add test and assertions Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index 640bfb2563c9775547a3ae451ebbf25edf0fc5ad..054adb456c53992d51ddc490a5af03955431f4d9 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -739,8 +739,8 @@ bool FrameLoaderClientImpl::willCheckAndDispatchMessageEvent(

return false;

WebFrame* source = 0;

- if (event && event->source() && event->source()->document())

- source = WebFrameImpl::fromFrame(event->source()->document()->frame());

+ if (event && event->source() && event->source()->toDOMWindow() && event->source()->toDOMWindow()->document())

+ source = WebFrameImpl::fromFrame(event->source()->toDOMWindow()->document()->frame());

return m_webFrame->client()->willCheckAndDispatchMessageEvent(

source, m_webFrame, WebSecurityOrigin(target), WebDOMMessageEvent(event));

}

« LayoutTests/fast/events/constructors/message-event-constructor.html ('K') | « Source/core/workers/SharedWorkerGlobalScope.cpp ('k') | no next file » | no next file with comments »