Source/core/workers/SharedWorkerGlobalScope.cpp - Issue 23319002: Set MessageEvent.source to the newly created port for shared workers' connect events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/SharedWorkerGlobalScope.cpp

Issue 23319002: Set MessageEvent.source to the newly created port for shared workers' connect events (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add test and assertions Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/constructors/message-event-constructor.html ('K') | « Source/core/dom/MessagePort.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/SharedWorkerGlobalScope.cpp

diff --git a/Source/core/workers/SharedWorkerGlobalScope.cpp b/Source/core/workers/SharedWorkerGlobalScope.cpp

index fe229eb0f97503c4c50b54e799ee37b9c0838c23..99453752e106a5855373c25c89eec8ac83727238 100644

--- a/Source/core/workers/SharedWorkerGlobalScope.cpp

+++ b/Source/core/workers/SharedWorkerGlobalScope.cpp

@@ -45,7 +45,8 @@ namespace WebCore {

PassRefPtr<MessageEvent> createConnectEvent(PassRefPtr<MessagePort> port)

{

- RefPtr<MessageEvent> event = MessageEvent::create(adoptPtr(new MessagePortArray(1, port)));

+ RefPtr<MessagePort> sourcePort = port;

+ RefPtr<MessageEvent> event = MessageEvent::create(adoptPtr(new MessagePortArray(1, sourcePort)), "", "", sourcePort);

event->initEvent(eventNames().connectEvent, false, false);

return event.release();

}

« LayoutTests/fast/events/constructors/message-event-constructor.html ('K') | « Source/core/dom/MessagePort.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »