Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2331803002: Add default case to test method. (Closed)

Created:
4 years, 3 months ago by slan
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add default case to test method. Some extra-picky compile warnings on internal Cast bots break our builds on this function. Add a default case to make them happy. BUG= Change-Id: Ic9495a3a82cbc40d34bbe9410c36492ce27663d7 Committed: https://crrev.com/d1d227e31aa7a316b69687c836831cebe36a3b32 Cr-Commit-Position: refs/heads/master@{#417972}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Logging macro update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/tools/quic/stateless_rejector_test.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
slan
Hey Ryan, changes in a recent CL (https://codereview.chromium.org/2308043003) broke internal Cast builders, which use stricter-than-normal ...
4 years, 3 months ago (2016-09-11 19:03:36 UTC) #4
Ryan Hamilton
LGTM modulo one tiny change. https://codereview.chromium.org/2331803002/diff/1/net/tools/quic/stateless_rejector_test.cc File net/tools/quic/stateless_rejector_test.cc (right): https://codereview.chromium.org/2331803002/diff/1/net/tools/quic/stateless_rejector_test.cc#newcode43 net/tools/quic/stateless_rejector_test.cc:43: NOTREACHED(); This code is ...
4 years, 3 months ago (2016-09-12 16:42:23 UTC) #7
slan
On 2016/09/12 16:42:23, Ryan Hamilton wrote: > LGTM modulo one tiny change. > > https://codereview.chromium.org/2331803002/diff/1/net/tools/quic/stateless_rejector_test.cc ...
4 years, 3 months ago (2016-09-12 16:59:51 UTC) #8
Ryan Hamilton
lgtm Thanks!
4 years, 3 months ago (2016-09-12 17:04:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331803002/20001
4 years, 3 months ago (2016-09-12 17:04:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 18:07:07 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 18:10:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1d227e31aa7a316b69687c836831cebe36a3b32
Cr-Commit-Position: refs/heads/master@{#417972}

Powered by Google App Engine
This is Rietveld 408576698