Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2308043003: Landing Recent QUIC changes until 5:55 PM, Aug 25, 2016 UTC-4 (Closed)

Created:
4 years, 3 months ago by Victor Vasiliev
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 5:55 PM, Aug 25, 2016 UTC-4 Change flags up to the state at Fri Sep 2 21:57:45 EDT 2016 https://codereview.chromium.org/2309613002/ Round results of multiplying QuicBandwidth and QuicTime::Delta rather than truncating. No behavior change expected. This will result in slightly more accurate time calculations, but should not make any real impact, since we should not be relying on microsecond-level-precision to that extent. Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=640984 Merge internal change: 131334594 https://codereview.chromium.org/2309603002/ Fix QUIC end to end tests to actually run the individual params one at a time as the comment says. Merge internal change: 131328806 https://codereview.chromium.org/2307253002/ Improve test case naming in stateless_rejector_test Old: [ RUN ] Flags/StatelessRejectorTest.InvalidChlo/0 New: [ RUN ] Flags/StatelessRejectorTest.InvalidChlo/v36_ENABLED Merge internal change: 131205533 https://codereview.chromium.org/2311543002/ Limits only 16 new QUIC connections can be opened per epoll event. Change QuicBufferedPacketStore to buffer early arrived packets as well as CHLO and use this to buffer CHLOs whose connection's creation is postponed. Protected by --quic_limit_num_new_sessions_per_epoll_loop. Merge internal change: 131102299 https://codereview.chromium.org/2310543002/ Include the two QUIC version sets in connection close details. Merge internal change: 131098194 https://codereview.chromium.org/2292083006/ Allow QUIC servers send a TTL for the server config, as opposed to explicit expiration, to mitigate client clock skew. Protected by enabled --quic_send_scfg_ttl. Merge internal change: 131052582 https://codereview.chromium.org/2305513003/ Add new connection option (BWS2) for an alternative bandwidth resumption experiment. Merge internal change: 131048253 https://codereview.chromium.org/2293173004/ Clean up QuicCryptoServerStream::GenerateConnectionIdForReject code Merge internal change: 130997336 https://codereview.chromium.org/2289363003/ Remove deprecated flag --quic_neuter_unencrypted_when_sending Merge internal change: 130989175 https://codereview.chromium.org/2297883002/ Store the QUIC server's crypto config expiration time explicitly in the client's CachedState, instead of parsing it out of the server config each time. In preparation for the REJ containing a TTL instead of an explicit expiration, to mitigate clock skew. Merge internal change: 130965621 https://codereview.chromium.org/2289243003/ R=rch@chromium.org BUG= Committed: https://crrev.com/9d4d65314f9dbf22c3d74cf995c261d588d0246c Cr-Commit-Position: refs/heads/master@{#416447}

Patch Set 1 #

Patch Set 2 : Fixes for various tests #

Patch Set 3 : Fixes for various tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+959 lines, -128 lines) Patch
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/congestion_control/rtt_stats_test.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.h View 4 chunks +8 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 8 chunks +29 lines, -16 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 3 chunks +29 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 7 chunks +23 lines, -2 lines 0 comments Download
M net/quic/core/quic_bandwidth.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/core/quic_bandwidth_test.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store.h View 4 chunks +32 lines, -5 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store.cc View 8 chunks +76 lines, -13 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store_test.cc View 1 10 chunks +192 lines, -26 lines 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 5 chunks +24 lines, -5 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/quic_crypto_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 3 chunks +12 lines, -7 lines 0 comments Download
M net/quic/core/quic_time.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/core/quic_time_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +15 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 6 chunks +58 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 7 chunks +231 lines, -19 lines 0 comments Download
M net/tools/quic/quic_server.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +115 lines, -0 lines 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 1 3 chunks +21 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Victor Vasiliev
4 years, 3 months ago (2016-09-03 02:11:42 UTC) #1
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-03 02:19:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308043003/1
4 years, 3 months ago (2016-09-03 02:20:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/63540)
4 years, 3 months ago (2016-09-03 02:41:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308043003/20001
4 years, 3 months ago (2016-09-03 04:25:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308043003/40001
4 years, 3 months ago (2016-09-03 04:46:18 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-03 05:49:00 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 05:52:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d4d65314f9dbf22c3d74cf995c261d588d0246c
Cr-Commit-Position: refs/heads/master@{#416447}

Powered by Google App Engine
This is Rietveld 408576698