Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2331793002: Apply first-line transform-text style (Closed)

Created:
4 years, 3 months ago by rhogan
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply first-line transform-text style A second go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658 BUG=129669, 644733 Committed: https://crrev.com/25c2cadce2d4a92f4f0f8b669fed2d097a6b7afa Cr-Commit-Position: refs/heads/master@{#418032}

Patch Set 1 #

Total comments: 1

Patch Set 2 : bug 129669 #

Patch Set 3 : bug 129669 #

Messages

Total messages: 21 (15 generated)
rhogan
https://codereview.chromium.org/2331793002/diff/1/third_party/WebKit/Source/core/layout/LayoutText.cpp File third_party/WebKit/Source/core/layout/LayoutText.cpp (right): https://codereview.chromium.org/2331793002/diff/1/third_party/WebKit/Source/core/layout/LayoutText.cpp#newcode1429 third_party/WebKit/Source/core/layout/LayoutText.cpp:1429: m_text.replace(from, len, textToCapitalize); A couple of things may have ...
4 years, 3 months ago (2016-09-12 18:58:25 UTC) #9
eae
OK, LGTM but let's keep an eye on the crash rate. Thank you so much ...
4 years, 3 months ago (2016-09-12 19:22:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331793002/40001
4 years, 3 months ago (2016-09-12 20:37:57 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-12 20:42:27 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/25c2cadce2d4a92f4f0f8b669fed2d097a6b7afa Cr-Commit-Position: refs/heads/master@{#418032}
4 years, 3 months ago (2016-09-12 20:44:40 UTC) #20
rhogan
4 years, 3 months ago (2016-09-13 21:27:07 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2337133004/ by robhogan@gmail.com.

The reason for reverting is: Still hitting clusterfuzz..

Powered by Google App Engine
This is Rietveld 408576698