Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 233173002: Clean-up in autofill_messages.h: IWYU (Closed)

Created:
6 years, 8 months ago by rchtara
Modified:
6 years, 8 months ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Clean-up in autofill_messages.h: IWYU Adding some missing #includes to autofill_messages.h. BUG=362057 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/autofill/content/common/autofill_messages.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rchtara
Hi Vaclav! So this the fix for the missing includes. I wanted just to checked ...
6 years, 8 months ago (2014-04-10 13:00:47 UTC) #1
vabr (Chromium)
Thanks Riadh! LGTM. Please find an OWNER (https://code.google.com/p/chromium/codesearch#chromium/src/components/autofill/content/common/OWNERS&sq=package:chromium) to review this as well. Cheers, Vaclav ...
6 years, 8 months ago (2014-04-10 14:02:54 UTC) #2
rchtara
Hi Vaclav, Awesome, thanks a lot Cheers Riadh
6 years, 8 months ago (2014-04-10 14:08:43 UTC) #3
rchtara
Hi Palmer, Could you please check this CL? Thanks a lot Cheers Riadh
6 years, 8 months ago (2014-04-10 14:12:44 UTC) #4
tfarina
this is very odd, and very one-off. How did you find this? By inspecting the ...
6 years, 8 months ago (2014-04-10 16:06:13 UTC) #5
vabr (Chromium)
On 2014/04/10 16:06:13, tfarina wrote: > this is very odd, and very one-off. How did ...
6 years, 8 months ago (2014-04-10 16:08:01 UTC) #6
palmer
LGTM
6 years, 8 months ago (2014-04-10 18:16:11 UTC) #7
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 8 months ago (2014-04-10 19:34:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchtara@chromium.org/233173002/1
6 years, 8 months ago (2014-04-10 19:36:14 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 23:09:16 UTC) #10
Message was sent while issue was closed.
Change committed as 263119

Powered by Google App Engine
This is Rietveld 408576698