Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
+#include <vector>

[Ilya Sherman, 2014/04/09 06:33:05]

Why did you add this?

[vabr (Chromium), 2014/04/09 11:17:13]

I asked Riadh to include that at a point when one of the messages had a
std::vector as an argument. That addition was dropped, but there are such
messages in the ToT version already. The style guide seems to require #including
all we use and cannot forward-declare, in particular templates
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Forwar...).
It's also what is done for std::string.

I'm not insisting on that change, though.

If we keep it, we should also
#include "base/strings/string16.h"

[Ilya Sherman, 2014/04/09 21:42:20]

If this is fixing up IWYU violations in existing code, then let's push those
fixes out to a separate CL.  I'm always happy to LGTM+CQ small cleanup CLs :) 
Thanks!

[vabr (Chromium), 2014/04/10 13:45:17]

I agree. Riadh, please disregard my previous request and remove the #include. If
you find spare time, do file a new clean-up CL for Include-What-You-Use. :)

 
 #include "base/time/time.h"
 #include "components/autofill/content/common/autofill_param_traits_macros.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/form_field_data_predictions.h"
 #include "components/autofill/core/common/forms_seen_state.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
@@ skipping 134 matching lines @@
 // autocomplete with the |form_data| values input by the user.
 IPC_MESSAGE_ROUTED2(AutofillMsg_RequestAutocompleteResult,
                     blink::WebFormElement::AutocompleteResult /* result */,
                     autofill::FormData /* form_data */)
 
 // Sent when Autofill manager gets the query response from the Autofill server
 // and there are fields classified as ACCOUNT_CREATION_PASSWORD in the response.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
                     std::vector<autofill::FormData> /* forms */)
 
+// Instruct the renderer that a password suggestion has to be removed.
+// The renderer is going to clean the suggestion from the ui and
+// then ask the password manager to remove the password from the store.
+IPC_MESSAGE_ROUTED1(AutofillMsg_RemoveSavedPassword,
+                    base::string16 /*user name to be removed */)

[Ilya Sherman, 2014/04/09 06:33:05]

How/why does the renderer deal with UI?  Patrick Dubroy is working on removing
knowledge of usernames and passwords from the renderer until they are filled.  I
think it's probably best to not send any IPC at all for removing passwords from
the data store.

[rchtara, 2014/04/09 13:52:43]

I'm not sure how it could be possible to not send any ipc.
The best thing I was able to do, with Vaclav, was to send just an empty msg by
removing the string16 parameter from the
AutofillMsg_RemoveSavedPassword. (see new patch)
The PasswordManager have to know which is the current selected PasswordForm, and
this is a why the second msg was send from the rendered. But there is probably
another way for doing so. But I'm not able to find it.
It would be great if you give us some suggestions.

[Ilya Sherman, 2014/04/09 21:42:20]

Please discuss this with Patrick Dubroy.  My suggestion might not make sense
w.r.t. the current state of the code, but ought to make sense after Patrick's
changes finish landing.  So as to not add code that we'll need to remove in a
week or two, I'd recommend either: (a) removing all IPC from this CL, and being
ok with an imperfect (but still pretty good) UX until Patrick's changes make it
in; or (b) delaying this CL until Patrick's changes have landed.

[vabr (Chromium), 2014/04/10 13:45:17]

Thanks, Ilya, for making us aware of the coming changes. I believe we need to
wait for Patrick then, he should be back in May. I advise against pushing out
only the IPC-less part -- this might generate confused bugreports, and also
after the planned code changes, some things might become easier to implement.

[Patrick Dubroy, 2014/04/29 12:47:06]

The browser renders the pop-up, but the suggestions themselves are still
provided by the renderer. Removing all login info from the renderer is out of
scope for my changes (it's not necessary to solve the Keychain prompting
problem), but I think we all agree that it would be nice to do.

+
 // Autofill messages sent from the renderer to the browser.
 
 // TODO(creis): check in the browser that the renderer actually has permission
 // for the URL to avoid compromised renderers talking to the browser.
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
 IPC_MESSAGE_ROUTED3(AutofillHostMsg_FormsSeen,
                     std::vector<autofill::FormData> /* forms */,
                     base::TimeTicks /* timestamp */,
@@ skipping 78 matching lines @@
                     autofill::PasswordFormFillData /* password pairings */)
 
 // Instruct the browser to show a popup with the following suggestions from the
 // password manager.
 IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
                     autofill::FormFieldData /* the form field */,
                     gfx::RectF /* input field bounds, window-relative */,
                     std::vector<base::string16> /* suggestions */,
                     std::vector<base::string16> /* realms */)
 
+// Instruct the browser that a saved password has to be removed.
+IPC_MESSAGE_ROUTED1(AutofillHostMsg_RemoveSavedPasswordAndUpdateManagers,
+                    autofill::PasswordForm /* the password form */)
+
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)