Add UMA for first app list paint on Windows.

Add UMA for first app list paint on Windows.


BUG=274049
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218723

[benwells, 2013-08-21 04:54:09]

Could we use the observer interface you recently introduced instead of a
callback?

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
File chrome/browser/ui/app_list/app_list_service.cc (right):

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_service.cc:38: return
base::CurrentProcessInfo::CreationTime();
Nit - indenting should be back two chars, this is an #if not an if().

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_service.cc:57: case WARM_START_FAST:
Nit: inside switch {} should be indented 2 more chars.
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Loops_...)

And below lines 89-99.

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_service.cc:90: case COLD_START:
Super nit: use same ordering of enum here as in the previous switch.

https://codereview.chromium.org/23315002/diff/1/ui/app_list/views/app_list_vi...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/23315002/diff/1/ui/app_list/views/app_list_vi...
ui/app_list/views/app_list_view.cc:176: g_next_paint_callback = base::Closure();
Should this be g_next_paint_callback.Reset()?

[koz (OOO until 15th September), 2013-08-21 06:54:21]

On 2013/08/21 04:54:09, benwells wrote:
> Could we use the observer interface you recently introduced instead of a
> callback?

As discussed, probably better to stick with the way it is now to avoid the
somewhat awkward lifetime and de-registration questions that using observers
introduces.

[koz (OOO until 15th September), 2013-08-21 06:54:32]

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
File chrome/browser/ui/app_list/app_list_service.cc (right):

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_service.cc:38: return
base::CurrentProcessInfo::CreationTime();
On 2013/08/21 04:54:09, benwells wrote:
> Nit - indenting should be back two chars, this is an #if not an if().

Done.

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_service.cc:57: case WARM_START_FAST:
On 2013/08/21 04:54:09, benwells wrote:
> Nit: inside switch {} should be indented 2 more chars.
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Loops_...)
> 
> And below lines 89-99.

Done.

https://codereview.chromium.org/23315002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_service.cc:90: case COLD_START:
On 2013/08/21 04:54:09, benwells wrote:
> Super nit: use same ordering of enum here as in the previous switch.

Done.

https://codereview.chromium.org/23315002/diff/1/ui/app_list/views/app_list_vi...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/23315002/diff/1/ui/app_list/views/app_list_vi...
ui/app_list/views/app_list_view.cc:176: g_next_paint_callback = base::Closure();
On 2013/08/21 04:54:09, benwells wrote:
> Should this be g_next_paint_callback.Reset()?

Done.

[benwells, 2013-08-21 07:01:06]

lgtm withanit

https://codereview.chromium.org/23315002/diff/6001/chrome/browser/ui/app_list...
File chrome/browser/ui/app_list/app_list_service.cc (right):

https://codereview.chromium.org/23315002/diff/6001/chrome/browser/ui/app_list...
chrome/browser/ui/app_list/app_list_service.cc:91: case COLD_START:
Nit: indenting still not right.

[koz (OOO until 15th September), 2013-08-21 07:21:43]

Thanks!

https://codereview.chromium.org/23315002/diff/6001/chrome/browser/ui/app_list...
File chrome/browser/ui/app_list/app_list_service.cc (right):

https://codereview.chromium.org/23315002/diff/6001/chrome/browser/ui/app_list...
chrome/browser/ui/app_list/app_list_service.cc:91: case COLD_START:
On 2013/08/21 07:01:06, benwells wrote:
> Nit: indenting still not right.

Third time's a charm!

[commit-bot: I haz the power, 2013-08-21 07:26:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/23315002/8001

[commit-bot: I haz the power, 2013-08-21 08:26:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-21 10:26:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/23315002/28001

[commit-bot: I haz the power, 2013-08-21 13:24:11]

Change committed as 218723