Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2331423005: Re-add common.gypi to help fix closure_compilation. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw, Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add common.gypi to help fix closure_compilation. This is a temporary fix until I can change the closure_compilation uses of gyp_chromium correctly. TBR=brettw@chromium.org, dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=646969

Patch Set 1 #

Patch Set 2 : remove presubmit check #

Total comments: 1

Patch Set 3 : remove msvs_cygwin_shell line to make presubmit happy #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+6350 lines, -0 lines) Patch
A build/common.gypi View 1 2 1 chunk +6347 lines, -0 lines 4 comments Download
M build/gyp_chromium.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Dan Beam
lgtm sorry again for all of this
4 years, 3 months ago (2016-09-15 00:56:31 UTC) #1
Dan Beam
https://codereview.chromium.org/2331423005/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2331423005/diff/20001/build/common.gypi#newcode3500 build/common.gypi:3500: 'Release': { fwiw: I think this is the only ...
4 years, 3 months ago (2016-09-15 00:58:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331423005/40001
4 years, 3 months ago (2016-09-15 01:00:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2687)
4 years, 3 months ago (2016-09-15 01:12:56 UTC) #8
Dan Beam
https://codereview.chromium.org/2331423005/diff/40001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2331423005/diff/40001/build/common.gypi#newcode2620 build/common.gypi:2620: 'includes': [ 'set_clang_warning_flags.gypi', ], axe this line https://codereview.chromium.org/2331423005/diff/40001/build/common.gypi#newcode3111 build/common.gypi:3111: ...
4 years, 3 months ago (2016-09-15 02:33:35 UTC) #9
Dan Beam
4 years, 3 months ago (2016-09-15 02:53:26 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698