Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: build/gyp_chromium.py

Issue 2331423005: Re-add common.gypi to help fix closure_compilation. (Closed)
Patch Set: remove msvs_cygwin_shell line to make presubmit happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium.py
diff --git a/build/gyp_chromium.py b/build/gyp_chromium.py
index 1572762a2658d6dc72539697771c041ae2fdd6be..53bb27a3a79e3110f7221f5c519b7cf9e9308deb 100644
--- a/build/gyp_chromium.py
+++ b/build/gyp_chromium.py
@@ -181,6 +181,9 @@ def additional_include_files(supplemental_files, args=[]):
if os.environ.get('GYP_INCLUDE_FIRST') != None:
AddInclude(os.path.join(chrome_src, os.environ.get('GYP_INCLUDE_FIRST')))
+ # Always include common.gypi.
+ AddInclude(os.path.join(script_dir, 'common.gypi'))
+
# Optionally add supplemental .gypi files if present.
for supplement in supplemental_files:
AddInclude(supplement)
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698