Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2331423004: Offline Pages - Removes the "ClearAllPages" API. (Closed)

Created:
4 years, 3 months ago by dewittj
Modified:
4 years, 2 months ago
Reviewers:
fgorski
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, arv+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Offline Pages - Removes the "ClearAllPages" API. This API is unused, cleaning up offline page model. BUG=622763 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e71c771311d6350f0264b3aa47c1d3aaabdd4492 Cr-Commit-Position: refs/heads/master@{#421226}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -113 lines) Patch
M components/offline_pages/offline_page_model.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 3 chunks +0 lines, -68 lines 0 comments Download
M components/offline_pages/offline_page_model_impl_unittest.cc View 1 3 chunks +0 lines, -30 lines 0 comments Download
M components/offline_pages/stub_offline_page_model.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages/stub_offline_page_model.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
dewittj
ptal, thanks!
4 years, 2 months ago (2016-09-27 14:01:54 UTC) #6
fgorski
lgtm
4 years, 2 months ago (2016-09-27 15:52:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331423004/20001
4 years, 2 months ago (2016-09-27 15:54:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 15:59:47 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 16:03:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e71c771311d6350f0264b3aa47c1d3aaabdd4492
Cr-Commit-Position: refs/heads/master@{#421226}

Powered by Google App Engine
This is Rietveld 408576698