Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2331423004: Offline Pages - Removes the "ClearAllPages" API. (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_model_impl_unittest.cc b/components/offline_pages/offline_page_model_impl_unittest.cc
index 3c988f6de248eef72cecd7eb3f9dfc8704f69cee..4a1a85dd502375d3abaaeca526380e0fda9aebbf 100644
--- a/components/offline_pages/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/offline_page_model_impl_unittest.cc
@@ -84,7 +84,6 @@ class OfflinePageModelImplTest
void OnSavePageDone(SavePageResult result, int64_t offline_id);
void OnDeletePageDone(DeletePageResult result);
void OnCheckPagesExistOfflineDone(const CheckPagesExistOfflineResult& result);
- void OnClearAllDone();
void OnGetOfflineIdsForClientIdDone(MultipleOfflineIdResult* storage,
const MultipleOfflineIdResult& result);
void OnGetSingleOfflinePageItemResult(const OfflinePageItem** storage,
@@ -246,10 +245,6 @@ void OfflinePageModelImplTest::OnCheckPagesExistOfflineDone(
last_pages_exist_result_ = result;
}
-void OfflinePageModelImplTest::OnClearAllDone() {
- PumpLoop();
-}
-
void OfflinePageModelImplTest::OnStoreUpdateDone(bool /* success - ignored */) {
}
@@ -966,31 +961,6 @@ TEST_F(OfflinePageModelImplTest, CanSaveURL) {
EXPECT_FALSE(OfflinePageModel::CanSaveURL(GURL("/invalid/url.mhtml")));
}
-TEST_F(OfflinePageModelImplTest, ClearAll) {
- SavePage(kTestUrl, kTestClientId1);
- SavePage(kTestUrl2, kTestClientId2);
-
- const std::vector<OfflinePageItem>& offline_pages = GetAllPages();
- EXPECT_EQ(2UL, offline_pages.size());
- EXPECT_EQ(2UL, GetStore()->GetAllPages().size());
- base::FilePath archiver_path = offline_pages[0].file_path;
- EXPECT_TRUE(base::PathExists(archiver_path));
-
- // ClearAll should delete all the files and wipe out both cache and store.
- model()->ClearAll(
- base::Bind(&OfflinePageModelImplTest::OnClearAllDone, AsWeakPtr()));
- PumpLoop();
- EXPECT_EQ(0UL, GetAllPages().size());
- EXPECT_EQ(0UL, GetStore()->GetAllPages().size());
- EXPECT_FALSE(base::PathExists(archiver_path));
-
- // The model should reload the store after the reset. All model operations
- // should continue to work.
- SavePage(kTestUrl2, kTestClientId2);
- EXPECT_EQ(1UL, GetAllPages().size());
- EXPECT_EQ(1UL, GetStore()->GetAllPages().size());
-}
-
TEST_F(OfflinePageModelImplTest, SaveRetrieveMultipleClientIds) {
EXPECT_FALSE(HasPages(kTestClientNamespace));
SavePage(kTestUrl, kTestClientId1);
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/stub_offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698