components/policy/core/common/cloud/external_policy_data_updater_unittest.cc - Issue 2331423002: Replace TestSimpleTaskRunner::GetPendingTasks with TakePendingTasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

Issue 2331423002: Replace TestSimpleTaskRunner::GetPendingTasks with TakePendingTasks (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/test/test_simple_task_runner.h ('K') | « components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc ('k') | components/policy/core/common/policy_statistics_collector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

diff --git a/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc b/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

index 2a1e0782563912e1747d4c90759434abc522bd45..4dd3fc77b0d6876396766b0badb084e1ad78b330 100644

--- a/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

+++ b/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

@@ -353,12 +353,11 @@ TEST_F(ExternalPolicyDataUpdaterTest, RetryWithBackoff) {

// Verify that the retry delay has been doubled, with random jitter from 80%

// to 100%.

- const base::TestPendingTask task =

- backend_task_runner_->GetPendingTasks().front();

- EXPECT_GT(task.delay,

+ base::TimeDelta delay = backend_task_runner_->NextPendingTaskDelay();

+ EXPECT_GT(delay,

base::TimeDelta::FromMilliseconds(

0.799 * expected_delay.InMilliseconds()));

- EXPECT_LE(task.delay, expected_delay);

+ EXPECT_LE(delay, expected_delay);

if (i < 10) {

// The delay cap has not been reached yet.