Replace TestSimpleTaskRunner::GetPendingTasks with TakePendingTasks

base/test/test_simple_task_runner.h

Index: base/test/test_simple_task_runner.h
diff --git a/base/test/test_simple_task_runner.h b/base/test/test_simple_task_runner.h
index eb600f40c3a68c9396614537993f1468b138b0bb..b071a41e669675119c213486ed65289244de1880 100644
--- a/base/test/test_simple_task_runner.h
+++ b/base/test/test_simple_task_runner.h
@@ -51,10 +51,12 @@ class TestSimpleTaskRunner : public SingleThreadTaskRunner {
 
   bool RunsTasksOnCurrentThread() const override;
 
-  std::deque<TestPendingTask> GetPendingTasks() const;
+  std::deque<TestPendingTask> TakePendingTasks();
   size_t NumPendingTasks() const;
   bool HasPendingTask() const;
   base::TimeDelta NextPendingTaskDelay() const;
+  base::TimeDelta FinalPendingTaskDelay() const;
+  tracked_objects::Location GetPendingTaskLocationAt(size_t index) const;

[danakj, 2016/09/21 22:16:59]

I don't think this is safe, in the time between NumPendingTasks and the call to
this, the index may not be valid anymore since you're not holding the |lock_|?

[pastarmovj, 2016/09/22 08:12:51]

+1 

Maybe take a snapshot of the deque with TakePendingTasks and assert its size and
contents instead. Then you don't need this function at all.

[tzik, 2016/09/29 05:58:04]

Ah, right. I updated it to return a base::Optional. Other data races should be
handled by the caller.

 
   // Clears the queue of pending tasks without running them.
   void ClearPendingTasks();