Add support for datalist to text input element on Android

ui/android/java/res/layout/autofill_text.xml

Index: ui/android/java/res/layout/autofill_text.xml
diff --git a/ui/android/java/res/layout/autofill_text.xml b/ui/android/java/res/layout/autofill_text.xml
index 4a69862a9163f44d7fc0f707cc5604410c3498b3..e495bc599be094b20dcf53607f72e2cb0c0f42ab 100644
--- a/ui/android/java/res/layout/autofill_text.xml
+++ b/ui/android/java/res/layout/autofill_text.xml
@@ -8,27 +8,33 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
               android:id="@+id/autofill_menu_text"
               android:layout_width="fill_parent"

[newt (away), 2013/09/10 17:45:10]

"fill_parent" -> "match_parent" everywhere

-              android:layout_height="44dp"
-              android:minHeight="44dp"
-              android:orientation="vertical"
-              android:gravity="center_vertical">
-  <TextView android:id="@+id/autofill_label"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:ellipsize="end"
-            android:singleLine="true"
-            android:textSize="18sp"
-            android:includeFontPadding="false"
-            android:layout_marginStart="10dp"
-            android:layout_marginEnd="10dp"/>
-  <TextView android:id="@+id/autofill_sublabel"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:textSize="14sp"
-            android:textColor="#8b8b8b"
-            android:ellipsize="end"
-            android:singleLine="true"
-            android:includeFontPadding="false"
-            android:layout_marginStart="10dp"
-            android:layout_marginEnd="10dp"/>
+              android:layout_height="wrap_content"
+              android:background="@drawable/autofill_divider"
+              android:orientation="vertical">
+    <LinearLayout android:id="@+id/autofill_menu_text"

[newt (away), 2013/09/09 20:20:42]

these two linearlayouts can be combined into one

[keishi, 2013/09/10 09:19:56]

I thought that maybe by using two LinearLayouts I can get the total height to be
44dp+1px(divider width).

[newt (away), 2013/09/10 17:45:10]

If you need to calculate this value (44dp+1px), you can do it in Java code. Or
just use 45dp.

Alternatively, you could also rid of minHeight, change layout_height to
"wrap_content", and add padding to make the LinearLayout the size you want. This
will work better anyway if the user changes their system font size. Something
like:

    <LinearLayout
        android:id="@+id/autofill_menu_text"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:orientation="vertical"
        android:paddingTop="6dp"
        android:paddingBottom="6dp" >

        <TextView android:id="@+id/autofill_label"
            ...

though this may not center the text the way you'd like.

[keishi, 2013/09/19 11:53:05]

I implemented 44dp + 1px.
The sublabel may or may not exist but we still want the same height for all
items so I think we can't do this.

+                  android:layout_width="fill_parent"
+                  android:layout_height="44dp"
+                  android:minHeight="44dp"
+                  android:orientation="vertical"
+                  android:gravity="center_vertical">
+      <TextView android:id="@+id/autofill_label"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:ellipsize="end"
+                android:singleLine="true"
+                android:textSize="18sp"
+                android:includeFontPadding="false"
+                android:layout_marginStart="10dp"
+                android:layout_marginEnd="10dp"/>
+      <TextView android:id="@+id/autofill_sublabel"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:textSize="14sp"
+                android:textColor="#8b8b8b"
+                android:ellipsize="end"
+                android:singleLine="true"
+                android:includeFontPadding="false"
+                android:layout_marginStart="10dp"
+                android:layout_marginEnd="10dp"/>
+    </LinearLayout>
 </LinearLayout>