ui/android/java/res/layout/autofill_text.xml - Issue 23314003: Add support for datalist to text input element on Android

Side by Side Diff: ui/android/java/res/layout/autofill_text.xml

Issue 23314003: Add support for datalist to text input element on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created custom drawable Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/child/runtime_features.cc ('k') | ui/android/java/res/values/colors.xml » ('j') | ui/android/java/src/org/chromium/ui/autofill/AutofillDividerDrawable.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

9 android:id="@+id/autofill_menu_text"	9 android:id="@+id/autofill_menu_text"

10 android:layout_width="fill_parent"	10 android:layout_width="fill_parent"
	newt (away) 2013/09/10 17:45:10 "fill_parent" -> "match_parent" everywhere "fill_parent" -> "match_parent" everywhere
11 android:layout_height="44dp"	11 android:layout_height="wrap_content"

12 android:minHeight="44dp"	12 android:background="@drawable/autofill_divider"

13 android:orientation="vertical"	13 android:orientation="vertical">

14 android:gravity="center_vertical">	14 <LinearLayout android:id="@+id/autofill_menu_text"
	newt (away) 2013/09/09 20:20:42 these two linearlayouts can be combined into one these two linearlayouts can be combined into one keishi 2013/09/10 09:19:56 I thought that maybe by using two LinearLayouts I Show quoted text On 2013/09/09 20:20:42, newt wrote: > these two linearlayouts can be combined into one I thought that maybe by using two LinearLayouts I can get the total height to be 44dp+1px(divider width). newt (away) 2013/09/10 17:45:10 If you need to calculate this value (44dp+1px), yo Show quoted text On 2013/09/10 09:19:56, keishi1 wrote: > On 2013/09/09 20:20:42, newt wrote: > > these two linearlayouts can be combined into one > > I thought that maybe by using two LinearLayouts I can get the total height to be > 44dp+1px(divider width). If you need to calculate this value (44dp+1px), you can do it in Java code. Or just use 45dp. Alternatively, you could also rid of minHeight, change layout_height to "wrap_content", and add padding to make the LinearLayout the size you want. This will work better anyway if the user changes their system font size. Something like: <LinearLayout android:id="@+id/autofill_menu_text" android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" android:paddingTop="6dp" android:paddingBottom="6dp" > <TextView android:id="@+id/autofill_label" ... though this may not center the text the way you'd like. keishi 2013/09/19 11:53:05 I implemented 44dp + 1px. Show quoted text On 2013/09/10 17:45:10, newt wrote: > On 2013/09/10 09:19:56, keishi1 wrote: > > On 2013/09/09 20:20:42, newt wrote: > > > these two linearlayouts can be combined into one > > > > I thought that maybe by using two LinearLayouts I can get the total height to > be > > 44dp+1px(divider width). > If you need to calculate this value (44dp+1px), you can do it in Java code. Or > just use 45dp. I implemented 44dp + 1px. Show quoted text > Alternatively, you could also rid of minHeight, change layout_height to > "wrap_content", and add padding to make the LinearLayout the size you want. This > will work better anyway if the user changes their system font size. Something > like: > > <LinearLayout > android:id="@+id/autofill_menu_text" > android:layout_width="match_parent" > android:layout_height="wrap_content" > android:orientation="vertical" > android:paddingTop="6dp" > android:paddingBottom="6dp" > > > <TextView android:id="@+id/autofill_label" > ... > > though this may not center the text the way you'd like. The sublabel may or may not exist but we still want the same height for all items so I think we can't do this.
15 <TextView android:id="@+id/autofill_label"	15 android:layout_width="fill_parent"

16 android:layout_width="wrap_content"	16 android:layout_height="44dp"

17 android:layout_height="wrap_content"	17 android:minHeight="44dp"

18 android:ellipsize="end"	18 android:orientation="vertical"

19 android:singleLine="true"	19 android:gravity="center_vertical">

20 android:textSize="18sp"	20 <TextView android:id="@+id/autofill_label"

21 android:includeFontPadding="false"	21 android:layout_width="wrap_content"

22 android:layout_marginStart="10dp"	22 android:layout_height="wrap_content"

23 android:layout_marginEnd="10dp"/>	23 android:ellipsize="end"

24 <TextView android:id="@+id/autofill_sublabel"	24 android:singleLine="true"

25 android:layout_width="wrap_content"	25 android:textSize="18sp"

26 android:layout_height="wrap_content"	26 android:includeFontPadding="false"

27 android:textSize="14sp"	27 android:layout_marginStart="10dp"

28 android:textColor="#8b8b8b"	28 android:layout_marginEnd="10dp"/>

29 android:ellipsize="end"	29 <TextView android:id="@+id/autofill_sublabel"

30 android:singleLine="true"	30 android:layout_width="wrap_content"

31 android:includeFontPadding="false"	31 android:layout_height="wrap_content"

32 android:layout_marginStart="10dp"	32 android:textSize="14sp"

33 android:layout_marginEnd="10dp"/>	33 android:textColor="#8b8b8b"

	34 android:ellipsize="end"

	35 android:singleLine="true"

	36 android:includeFontPadding="false"

	37 android:layout_marginStart="10dp"

	38 android:layout_marginEnd="10dp"/>

	39 </LinearLayout>

34 </LinearLayout>	40 </LinearLayout>

OLD	NEW