Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2331373006: Enable incremental linking in release component builds (Closed)
Patch Set: Tweak logic and add bug link Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 8207107b5dc8d8e88c00f16a46bf0ce1e820dff8..ddd88650e81e5ddd8a592c522b873cdb558e0c14 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -180,8 +180,10 @@ component("core") {
if (is_win && is_debug && is_component_build && current_cpu == "x64") {
# Incremental linking doesn't work on this target in debug mode for
# 64-bit builds - the .ilk file gets too large and the incremental
- # link silently fails. Therefore 32-bit builds should be used for
- # fastest incremental build performance.
+ # link silently fails. Therefore 32-bit builds or 64-bit release builds
+ # (component either way) should be used for fastest incremental build
+ # performance. VC++ bug filed for 64-bit debug incremental link failures:
+ # https://connect.microsoft.com/VisualStudio/feedback/details/2846790
configs -= [ "//build/config/win:default_incremental_linking" ]
configs += [ "//build/config/win:no_incremental_linking" ]
}
« no previous file with comments | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698