Harden an API that takes base::StringPiece to give a compile error if

Harden an API that takes base::StringPiece to give a compile error if
ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.

BUG=634443
Committed: https://crrev.com/4c511204009505c9bc9193785ea3c109a4e2a227
Cr-Commit-Position: refs/heads/master@{#418593}

[eroman, 2016-09-13 23:53:16]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:53:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-13 23:55:09]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2016-09-13 23:55:09]

This seems really silly, but I hit this bug no less than 3 times while doing the
previous refactor, and it seems absurd that it wouldn't be a compile error.

Arguably our codebase is confused about what a StringPiece is since we use it
for both strings and binary blobs... but that is a separate issue.

[commit-bot: I haz the power, 2016-09-14 00:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:57:40]

Dry run: This issue passed the CQ dry run.

[mattm, 2016-09-14 02:31:15]

lgtm

[eroman, 2016-09-14 16:52:00]

Description was changed from

==========
Harden an API that takes base::StringPiece to give a compile error if
ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.
==========

to

==========
Harden an API that takes base::StringPiece to give a compile error if
ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.

BUG=634443
==========

[eroman, 2016-09-14 16:52:12]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-09-14 16:52:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:57:40]

Description was changed from

==========
Harden an API that takes base::StringPiece to give a compile error if
ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.

BUG=634443
==========

to

==========
Harden an API that takes base::StringPiece to give a compile error if
ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.

BUG=634443
==========

[commit-bot: I haz the power, 2016-09-14 16:57:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-14 17:00:56]

Description was changed from

==========
Harden an API that takes base::StringPiece to give a compile error if
ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.

BUG=634443
==========

to

==========
Harden an API that takes base::StringPiece to give a compile error if
ever a naked const char* is passed in.

I hit this bug while doing a refactor, so ensuring it can't happen
again for this callsite seems prudent.

BUG=634443

Committed: https://crrev.com/4c511204009505c9bc9193785ea3c109a4e2a227
Cr-Commit-Position: refs/heads/master@{#418593}
==========

[commit-bot: I haz the power, 2016-09-14 17:00:57]

Patchset 1 (id:??) landed as
https://crrev.com/4c511204009505c9bc9193785ea3c109a4e2a227
Cr-Commit-Position: refs/heads/master@{#418593}