Harden an API that takes base::StringPiece to give a compile error if

net/cert/internal/parsed_certificate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_INTERNAL_PARSED_CERTIFICATE_H_
 #define NET_CERT_INTERNAL_PARSED_CERTIFICATE_H_
 
 #include <map>
 #include <memory>
 #include <vector>
@@ skipping 209 matching lines @@
   ParsedCertificate();
   ~ParsedCertificate();
 
   static scoped_refptr<ParsedCertificate> CreateInternal(
       const uint8_t* data,
       size_t length,
       DataSource source,
       const ParseCertificateOptions& options,
       CertErrors* errors);
 
+  // These private overloads should not be used, and have no definition.
+  //
+  // They are here to prevent incorrectly passing a const char*
+  // in place of a base::StringPiece (thanks to StringPiece implicit
+  // ctor on const char*).
+  //
+  // Accidentally inflating a const char* (without length) to a
+  // StringPiece would be a bug.
+  static scoped_refptr<ParsedCertificate> Create(
+      const char* invalid_data,
+      const ParseCertificateOptions& options,
+      CertErrors* errors);
+  static bool CreateAndAddToVector(
+      const char* data,
+      const ParseCertificateOptions& options,
+      std::vector<scoped_refptr<net::ParsedCertificate>>* chain,
+      CertErrors* errors);
+
   // The backing store for the certificate data. This is only applicable when
   // the ParsedCertificate was initialized using DataSource::INTERNAL_COPY.
   std::vector<uint8_t> cert_data_;
 
   // Note that the backing data for |cert_| (and its  may come either from
   // |cert_data_| or some external buffer (depending on how the
   // ParsedCertificate was created).
 
   // Points to the raw certificate DER.
   der::Input cert_;
@@ skipping 38 matching lines @@
 
   // The remaining extensions (excludes the standard ones above).
   ExtensionsMap unparsed_extensions_;
 
   DISALLOW_COPY_AND_ASSIGN(ParsedCertificate);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_INTERNAL_PARSED_CERTIFICATE_H_