Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2331153002: [Merge to 2840] Fix a bug where inactive windows would inappropriately take focus. (Closed)

Created:
4 years, 3 months ago by erikchen
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge to 2840] Fix a bug where inactive windows would inappropriately take focus. > On Windows, it's not possible to focus a widget without activating the window. > As a result, the semantics for RenderWidgetHostView::Focus include window > activation on all platforms. > > The previous implementation for UpdateUIForNavigationInTab would focus the web > contents, even if the window is backgrounded. This would activate the window. > This manifested itself most clearly during session restore for two windows, when > activation would bounce between the two windows, sometimes as many as 10 times!. > > The new implementation only focuses the contents if the window is activated, or > about to be activated. If the window is backgrounded, then the appropriate > content will be focused when the user chooses the activate the window. > > BUG=634248 > > Review-Url: https://codereview.chromium.org/2284573004 > Cr-Commit-Position: refs/heads/master@{#415472} > (cherry picked from commit 0de48e14a7008fa85d9d74439a7dd63b413abb13) Committed: https://chromium.googlesource.com/chromium/src/+/c6d4e388aea582cb1cf12a95c3366186d0842b6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M chrome/browser/ui/browser.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 3 months ago (2016-09-12 20:54:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6d4e388aea582cb1cf12a95c3366186d0842b6f.

Powered by Google App Engine
This is Rietveld 408576698