Don't allow navigations in inactive windows to change window focus.

Fix a bug where inactive windows would inappropriately take focus.

On Windows, it's not possible to focus a widget without activating the window.
As a result, the semantics for RenderWidgetHostView::Focus include window
activation on all platforms.

The previous implementation for UpdateUIForNavigationInTab would focus the web
contents, even if the window is backgrounded. This would activate the window.
This manifested itself most clearly during session restore for two windows, when
activation would bounce between the two windows, sometimes as many as 10 times!.

The new implementation only focuses the contents if the window is activated, or
about to be activated. If the window is backgrounded, then the appropriate
content will be focused when the user chooses the activate the window.

BUG=634248
Committed: https://crrev.com/0de48e14a7008fa85d9d74439a7dd63b413abb13
Cr-Commit-Position: refs/heads/master@{#415472}

[erikchen, 2016-08-26 23:56:02]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 23:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:25:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-08-29 20:07:02]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 20:51:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-08-29 22:43:07]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 23:27:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:39:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-08-30 17:43:22]

Description was changed from

==========
Don't allow navigations in inactive windows to change window focus.

BUG=
==========

to

==========
Fix a bug where inactive windows would inappropriately take focus.

On Windows, it's not possible to focus a widget without activating the window.
As a result, the semantics for RenderWidgetHostView::Focus include window
activation on all platforms.

The previous implementation for UpdateUIForNavigationInTab would focus the web
contents, even if the window is backgrounded. This would activate the window.
This manifested itself most clearly during session restore for two windows, when
activation would bounce between the two windows, sometimes as many as 10 times!.

The new implementation only focuses the contents if the window is activated, or
about to be activated. If the window is backgrounded, then the appropriate
content will be focused when the user chooses the activate the window.

This CL also changes browser_tests and interactive_ui_tests on Mac to allow the
window to be activated, to match the behavior on other platforms.

BUG=634248
==========

[erikchen, 2016-08-30 17:43:46]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 17:44:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:13:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-08-30 19:56:07]

Description was changed from

==========
Fix a bug where inactive windows would inappropriately take focus.

On Windows, it's not possible to focus a widget without activating the window.
As a result, the semantics for RenderWidgetHostView::Focus include window
activation on all platforms.

The previous implementation for UpdateUIForNavigationInTab would focus the web
contents, even if the window is backgrounded. This would activate the window.
This manifested itself most clearly during session restore for two windows, when
activation would bounce between the two windows, sometimes as many as 10 times!.

The new implementation only focuses the contents if the window is activated, or
about to be activated. If the window is backgrounded, then the appropriate
content will be focused when the user chooses the activate the window.

This CL also changes browser_tests and interactive_ui_tests on Mac to allow the
window to be activated, to match the behavior on other platforms.

BUG=634248
==========

to

==========
Fix a bug where inactive windows would inappropriately take focus.

On Windows, it's not possible to focus a widget without activating the window.
As a result, the semantics for RenderWidgetHostView::Focus include window
activation on all platforms.

The previous implementation for UpdateUIForNavigationInTab would focus the web
contents, even if the window is backgrounded. This would activate the window.
This manifested itself most clearly during session restore for two windows, when
activation would bounce between the two windows, sometimes as many as 10 times!.

The new implementation only focuses the contents if the window is activated, or
about to be activated. If the window is backgrounded, then the appropriate
content will be focused when the user chooses the activate the window.

BUG=634248
==========

[erikchen, 2016-08-30 19:56:26]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 19:56:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:56:45]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-08-30 20:59:06]

erikchen@chromium.org changed reviewers:
+ sky@chromium.org

[erikchen, 2016-08-30 20:59:07]

sky: Please review.

[sky, 2016-08-30 22:09:07]

https://codereview.chromium.org/2284573004/diff/100001/chrome/test/base/web_u...
File chrome/test/base/web_ui_browser_test.cc (right):

https://codereview.chromium.org/2284573004/diff/100001/chrome/test/base/web_u...
chrome/test/base/web_ui_browser_test.cc:230: // widget cannot be focused without
window activation. browser_tests can be
interactive_ui_tests aren't sharded and are used when you need to test things
like system level activation. Should this test move there?

[erikchen, 2016-08-30 22:17:12]

https://codereview.chromium.org/2284573004/diff/100001/chrome/test/base/web_u...
File chrome/test/base/web_ui_browser_test.cc (right):

https://codereview.chromium.org/2284573004/diff/100001/chrome/test/base/web_u...
chrome/test/base/web_ui_browser_test.cc:230: // widget cannot be focused without
window activation. browser_tests can be
On 2016/08/30 22:09:07, sky wrote:
> interactive_ui_tests aren't sharded and are used when you need to test things
> like system level activation. Should this test move there?

Yes. I filed a bug against the team that wrote this test. Please see the crbug
linked in the comment: https://crbug.com/642467

[sky, 2016-08-30 22:39:48]

LGTM

[erikchen, 2016-08-30 22:40:03]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:40:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 22:46:55]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-30 22:49:31]

Description was changed from

==========
Fix a bug where inactive windows would inappropriately take focus.

On Windows, it's not possible to focus a widget without activating the window.
As a result, the semantics for RenderWidgetHostView::Focus include window
activation on all platforms.

The previous implementation for UpdateUIForNavigationInTab would focus the web
contents, even if the window is backgrounded. This would activate the window.
This manifested itself most clearly during session restore for two windows, when
activation would bounce between the two windows, sometimes as many as 10 times!.

The new implementation only focuses the contents if the window is activated, or
about to be activated. If the window is backgrounded, then the appropriate
content will be focused when the user chooses the activate the window.

BUG=634248
==========

to

==========
Fix a bug where inactive windows would inappropriately take focus.

On Windows, it's not possible to focus a widget without activating the window.
As a result, the semantics for RenderWidgetHostView::Focus include window
activation on all platforms.

The previous implementation for UpdateUIForNavigationInTab would focus the web
contents, even if the window is backgrounded. This would activate the window.
This manifested itself most clearly during session restore for two windows, when
activation would bounce between the two windows, sometimes as many as 10 times!.

The new implementation only focuses the contents if the window is activated, or
about to be activated. If the window is backgrounded, then the appropriate
content will be focused when the user chooses the activate the window.

BUG=634248

Committed: https://crrev.com/0de48e14a7008fa85d9d74439a7dd63b413abb13
Cr-Commit-Position: refs/heads/master@{#415472}
==========

[commit-bot: I haz the power, 2016-08-30 22:49:32]

Patchset 6 (id:??) landed as
https://crrev.com/0de48e14a7008fa85d9d74439a7dd63b413abb13
Cr-Commit-Position: refs/heads/master@{#415472}