Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3438)

Unified Diff: chrome/browser/ui/views/frame/browser_frame.cc

Issue 2331093002: UMA stats for stylus usage (Closed)
Patch Set: Incorporate comments from xiyuan@ and mpearson@ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_frame.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame.cc b/chrome/browser/ui/views/frame/browser_frame.cc
index 2cbb1850d2cc9227c5a68f16dd03fb9444b420f8..b84738a88e1383a9943133173305e0057f9d51df 100644
--- a/chrome/browser/ui/views/frame/browser_frame.cc
+++ b/chrome/browser/ui/views/frame/browser_frame.cc
@@ -35,6 +35,7 @@
#if defined(OS_CHROMEOS)
#include "ash/common/session/session_state_delegate.h" // nogncheck
#include "ash/common/wm_shell.h" // nogncheck
+#include "chrome/browser/ui/ash/metrics/stylus_metrics_recorder_chromeos.h"
#include "ui/native_theme/native_theme_dark_aura.h" // nogncheck
#endif
@@ -99,6 +100,12 @@ void BrowserFrame::InitBrowserFrame() {
Init(params);
+#if defined(OS_CHROMEOS)
+ browser_view_->GetNativeWindow()->SetProperty(
+ chromeos::kStylusWindowTypeBucket,
+ chromeos::StylusWindowType::WINDOW_TYPE_BROWSER_WINDOW);
sky 2016/09/16 23:20:17 This also includes things like popups. Are you sur
xiaoyinh(OOO Sep 11-29) 2016/09/19 21:19:53 Moved to BrowserNonClientFrameViewAsh::Init() I f
sky 2016/09/19 23:36:53 I'm not familiar with what you're considering 'bro
+#endif
+
if (!native_browser_frame_->UsesNativeSystemMenu()) {
DCHECK(non_client_view());
non_client_view()->set_context_menu_controller(this);

Powered by Google App Engine
This is Rietveld 408576698