UMA stats for stylus usage

chrome/browser/ui/views/frame/browser_frame.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/debug/leak_annotations.h"
@@ skipping 17 matching lines @@
 #include "ui/base/hit_test.h"
 #include "ui/events/event_handler.h"
 #include "ui/gfx/font_list.h"
 #include "ui/views/controls/menu/menu_model_adapter.h"
 #include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/widget/native_widget.h"
 
 #if defined(OS_CHROMEOS)
 #include "ash/common/session/session_state_delegate.h"  // nogncheck
 #include "ash/common/wm_shell.h"  // nogncheck
+#include "chrome/browser/ui/ash/metrics/stylus_metrics_recorder_chromeos.h"
 #include "ui/native_theme/native_theme_dark_aura.h"  // nogncheck
 #endif
 
 #if defined(OS_LINUX)
 #include "chrome/browser/ui/views/frame/browser_command_handler_linux.h"
 #endif
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
 #include "ui/views/widget/desktop_aura/x11_desktop_handler.h"
 #endif
@@ skipping 44 matching lines @@
         *base::CommandLine::ForCurrentProcess();
 
     if (parsed_command_line.HasSwitch(switches::kWindowWorkspace)) {
       params.workspace =
           parsed_command_line.GetSwitchValueASCII(switches::kWindowWorkspace);
     }
   }
 
   Init(params);
 
+#if defined(OS_CHROMEOS)
+  browser_view_->GetNativeWindow()->SetProperty(
+      chromeos::kStylusWindowTypeBucket,
+      chromeos::StylusWindowType::WINDOW_TYPE_BROWSER_WINDOW);

[sky, 2016/09/16 23:20:17]

This also includes things like popups. Are you sure you want them lumped with
BROWSER_WINDOWS? Also, move this to BrowserNonClientFrameViewAsh as that is the
only place that really cares about it.

[xiaoyinh(OOO Sep 11-29), 2016/09/19 21:19:53]

Moved to BrowserNonClientFrameViewAsh::Init()

I feel that popup windows could also be counted as down events on browser window
because it happens during the web browsing. Let me know if you think otherwise. 

If we are going to rule out the popup, could I use widget type TYPE_POPUP to
check it?

[sky, 2016/09/19 23:36:53]

I'm not familiar with what you're considering 'browser' window. I wanted to make
sure you were aware this code is hit for popups too. If you want popups in that
too, that's fine. If you want to rule out popups you would check the browser
type. In fact the browser type may include apps. See Browser::is_app().

+#endif
+
   if (!native_browser_frame_->UsesNativeSystemMenu()) {
     DCHECK(non_client_view());
     non_client_view()->set_context_menu_controller(this);
   }
 
 #if defined(OS_LINUX)
   browser_command_handler_.reset(new BrowserCommandHandlerLinux(browser_view_));
 #endif
 }
 
@@ skipping 182 matching lines @@
 }
 
 views::View* BrowserFrame::GetNewAvatarMenuButton() {
   return browser_frame_view_->GetProfileSwitcherView();
 }
 
 void BrowserFrame::OnMenuClosed() {
   menu_model_adapter_.reset();
   menu_runner_.reset();
 }