Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2673)

Unified Diff: ash/shared/app_types.h

Issue 2331093002: UMA stats for stylus usage (Closed)
Patch Set: Changed ash/BUILD.gn Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shared/app_types.h
diff --git a/ash/shared/app_types.h b/ash/shared/app_types.h
new file mode 100644
index 0000000000000000000000000000000000000000..7741ce780be5118fc478e0108660fccaee25a018
--- /dev/null
+++ b/ash/shared/app_types.h
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_SHARED_APP_TYPES_H_
+#define ASH_SHARED_APP_TYPES_H_
+
+namespace ash {
+
+// App type of the window. This enum is used to back
+// an UMA histogram and should be treated as append-only.
+enum class AppType {
+ OTHERS = 0,
+ BROWSER,
+ CHROME_APP,
+ ARC_APP,
+ DEFAULT_NOTE_TAKING_APP,
sky 2016/09/27 22:08:59 Why the DEFAULT_ here instead of NOTE_TAKING_APP?
Daniel Erat 2016/09/27 23:34:09 i'm fine with dropping the DEFAULT_ here. (as back
xiaoyinh(OOO Sep 11-29) 2016/09/29 20:37:43 Thanks for the explanation.
+ APP_COUNT,
sky 2016/09/27 22:08:59 I would prefer you define a constant outside the e
xiaoyinh(OOO Sep 11-29) 2016/09/29 20:37:43 Done.
+};
+
+} // namespace ash
+
+#endif // ASH_SHARED_APP_TYPES_H_

Powered by Google App Engine
This is Rietveld 408576698