ash/shared/app_types.h - Issue 2331093002: UMA stats for stylus usage

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/shared/app_types.h

Issue 2331093002: UMA stats for stylus usage (Closed)

Patch Set: Changed ash/BUILD.gn Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ASH_SHARED_APP_TYPES_H_

	6 #define ASH_SHARED_APP_TYPES_H_

	7

	8 namespace ash {

	9

	10 // App type of the window. This enum is used to back

	11 // an UMA histogram and should be treated as append-only.

	12 enum class AppType {

	13 OTHERS = 0,

	14 BROWSER,

	15 CHROME_APP,

	16 ARC_APP,

	17 DEFAULT_NOTE_TAKING_APP,
	sky 2016/09/27 22:08:59 Why the DEFAULT_ here instead of NOTE_TAKING_APP? Why the DEFAULT_ here instead of NOTE_TAKING_APP? Daniel Erat 2016/09/27 23:34:09 i'm fine with dropping the DEFAULT_ here. (as back Show quoted text On 2016/09/27 22:08:59, sky wrote: > Why the DEFAULT_ here instead of NOTE_TAKING_APP? i'm fine with dropping the DEFAULT_ here. (as background, there will be a setting by which the user can select a note-taking app that will be launched in various places in the UI.) xiaoyinh(OOO Sep 11-29) 2016/09/29 20:37:43 Thanks for the explanation. Show quoted text On 2016/09/27 23:34:09, Daniel Erat wrote: > On 2016/09/27 22:08:59, sky wrote: > > Why the DEFAULT_ here instead of NOTE_TAKING_APP? > > i'm fine with dropping the DEFAULT_ here. (as background, there will be a > setting by which the user can select a note-taking app that will be launched in > various places in the UI.) Thanks for the explanation.
	18 APP_COUNT,
	sky 2016/09/27 22:08:59 I would prefer you define a constant outside the e I would prefer you define a constant outside the enum for this. That way anyone wanting to handle a switch statement doesn't have to deal with APP_COUNT. xiaoyinh(OOO Sep 11-29) 2016/09/29 20:37:43 Done. Show quoted text On 2016/09/27 22:08:59, sky wrote: > I would prefer you define a constant outside the enum for this. That way anyone > wanting to handle a switch statement doesn't have to deal with APP_COUNT. Done.
	19 };

	20

	21 } // namespace ash

	22

	23 #endif // ASH_SHARED_APP_TYPES_H_

OLD	NEW

« ash/metrics/user_metrics_recorder.cc ('K') | « ash/shared/BUILD.gn ('k') | ash/shell.h » ('j') | chrome/browser/chromeos/note_taking_app_utils.h » ('J')