Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/common/page_load_metrics/page_track_decider.cc

Issue 2331053003: Add common page filtering logic for page load metrics. (Closed)
Patch Set: fix method names to be consistent with style guide Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/page_load_metrics/page_track_decider.h ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/page_load_metrics/page_track_decider.cc
diff --git a/chrome/common/page_load_metrics/page_track_decider.cc b/chrome/common/page_load_metrics/page_track_decider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..457532a83f03eabfa76740f5d563d62c41859977
--- /dev/null
+++ b/chrome/common/page_load_metrics/page_track_decider.cc
@@ -0,0 +1,40 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/page_load_metrics/page_track_decider.h"
+
+namespace page_load_metrics {
+
+PageTrackDecider::PageTrackDecider() {}
+PageTrackDecider::~PageTrackDecider() {}
+
+bool PageTrackDecider::ShouldTrack() {
+ // Ignore non-HTTP schemes (e.g. chrome://).
+ if (!IsHttpOrHttpsUrl())
+ return false;
+
+ // Ignore NTP loads.
+ if (IsNewTabPageUrl())
+ return false;
+
+ if (HasCommitted()) {
+ // Ignore Chrome error pages (e.g. No Internet connection).
+ if (IsChromeErrorPage())
+ return false;
+
+ // Ignore non-HTML documents (e.g. SVG, images).
+ if (!IsHtmlOrXhtmlPage())
+ return false;
+
+ // Ignore network error pages (e.g. 4xx, 5xx).
+ int http_status_code = GetHttpStatusCode();
+ if (http_status_code > 0 &&
+ (http_status_code < 200 || http_status_code >= 400))
+ return false;
+ }
+
+ return true;
+}
+
+} // namespace page_load_metrics
« no previous file with comments | « chrome/common/page_load_metrics/page_track_decider.h ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698