Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/common/page_load_metrics/page_track_decider.cc

Issue 2331053003: Add common page filtering logic for page load metrics. (Closed)
Patch Set: fix method names to be consistent with style guide Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/page_load_metrics/page_track_decider.h ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/page_load_metrics/page_track_decider.h"
6
7 namespace page_load_metrics {
8
9 PageTrackDecider::PageTrackDecider() {}
10 PageTrackDecider::~PageTrackDecider() {}
11
12 bool PageTrackDecider::ShouldTrack() {
13 // Ignore non-HTTP schemes (e.g. chrome://).
14 if (!IsHttpOrHttpsUrl())
15 return false;
16
17 // Ignore NTP loads.
18 if (IsNewTabPageUrl())
19 return false;
20
21 if (HasCommitted()) {
22 // Ignore Chrome error pages (e.g. No Internet connection).
23 if (IsChromeErrorPage())
24 return false;
25
26 // Ignore non-HTML documents (e.g. SVG, images).
27 if (!IsHtmlOrXhtmlPage())
28 return false;
29
30 // Ignore network error pages (e.g. 4xx, 5xx).
31 int http_status_code = GetHttpStatusCode();
32 if (http_status_code > 0 &&
33 (http_status_code < 200 || http_status_code >= 400))
34 return false;
35 }
36
37 return true;
38 }
39
40 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « chrome/common/page_load_metrics/page_track_decider.h ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698