Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2330993002: macviews: fix mac_views_browser=1 build (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macviews: fix mac_views_browser=1 build All the sources for Views marked !is_mac should instead have been !is_mac || mac_views_browser, except for mus, which doesn't build on Mac or any platform where gfx::AcceleratedWidget and gpu::SurfaceHandle are different types. BUG= Committed: https://crrev.com/4c5b6cd78865ac20dbae29297627a513c5590863 Cr-Commit-Position: refs/heads/master@{#417992}

Patch Set 1 #

Total comments: 1

Patch Set 2 : explodes -> fails to build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Elly Fong-Jones
msw: ptal? :)
4 years, 3 months ago (2016-09-12 14:05:24 UTC) #3
msw
lgtm with a nit. https://codereview.chromium.org/2330993002/diff/1/chrome/browser/ui/BUILD.gn File chrome/browser/ui/BUILD.gn (right): https://codereview.chromium.org/2330993002/diff/1/chrome/browser/ui/BUILD.gn#newcode1843 chrome/browser/ui/BUILD.gn:1843: # TODO(ellyjones): This target explodes ...
4 years, 3 months ago (2016-09-12 17:29:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330993002/20001
4 years, 3 months ago (2016-09-12 17:44:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 19:07:56 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 19:11:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c5b6cd78865ac20dbae29297627a513c5590863
Cr-Commit-Position: refs/heads/master@{#417992}

Powered by Google App Engine
This is Rietveld 408576698