Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6686)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2330993002: macviews: fix mac_views_browser=1 build (Closed)
Patch Set: explodes -> fails to build Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index d216919574d0875dabe1a720a647db946f2c773e..52ce4809e9ea37f057b1e9cee1fd09c046de2111 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -1544,7 +1544,7 @@ split_static_library("ui") {
]
}
}
- if (!is_mac) {
+ if (!is_mac || mac_views_browser) {
sources += [
# This test header is included because it contains forward declarations
# needed for "friend" statements for use in tests.
@@ -1839,7 +1839,12 @@ split_static_library("ui") {
"views/tabs/window_finder_mus.h",
]
}
- deps += [ "//ui/views/mus" ]
+
+ # TODO(ellyjones): This target fails to build on Mac because of
+ # incompatible uses of gpu::AcceleratedWidget vs gpu::SurfaceHandle.
+ if (!is_mac) {
+ deps += [ "//ui/views/mus" ]
+ }
}
if (use_ash) {
sources += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698