Chromium Code Reviews| Index: third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h |
| diff --git a/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h b/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h |
| index fef230697c1665313462b4307adfa01461c6d839..2589f56e32caad8f040d11ba169b7b7fc10a69df 100644 |
| --- a/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h |
| +++ b/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h |
| @@ -13,18 +13,33 @@ class CSSValue; |
| enum class CSSSyntaxType { |
| TokenStream, |
| + Ident, |
| Length, |
| - // TODO(timloh): Add all the other types |
| + Number, |
| + Percentage, |
| + LengthPercentage, |
| + Color, |
| + Image, |
| + Url, |
| + Integer, |
| + Angle, |
| + Time, |
| + Resolution, |
| + TransformFunction, |
| + CustomIdent, |
|
meade_UTC10
2016/09/14 12:54:13
Should these be alphabetised?
Timothy Loh
2016/09/19 07:14:14
These (Length->CustomIdent) are ordered the same a
|
| }; |
| struct CSSSyntaxComponent { |
| - CSSSyntaxComponent(CSSSyntaxType type) |
| + CSSSyntaxComponent(CSSSyntaxType type, const String& string, bool repeatable) |
| : m_type(type) |
| + , m_string(string) |
| + , m_repeatable(repeatable) |
| { |
| } |
| CSSSyntaxType m_type; |
| - // TODO(timloh): This will need to support arbitrary idents and list types |
| + String m_string; // Only used when m_type is CSSSyntaxType::Ident |
| + bool m_repeatable; |
| }; |
| class CSSSyntaxDescriptor { |