CSS Properties and Values API: Support more syntax strings

third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CSSSyntaxDescriptor_h
 #define CSSSyntaxDescriptor_h
 
 #include "core/css/parser/CSSParserTokenRange.h"
 
 namespace blink {
 
 class CSSValue;
 
 enum class CSSSyntaxType {
     TokenStream,
+    Ident,
     Length,
-    // TODO(timloh): Add all the other types
+    Number,
+    Percentage,
+    LengthPercentage,
+    Color,
+    Image,
+    Url,
+    Integer,
+    Angle,
+    Time,
+    Resolution,
+    TransformFunction,
+    CustomIdent,

[meade_UTC10, 2016/09/14 12:54:13]

Should these be alphabetised?

[Timothy Loh, 2016/09/19 07:14:14]

These (Length->CustomIdent) are ordered the same as in the spec. I don't have
any strong preference for order here -- I just left them as is but LMK if you'd
prefer I changed it.

 };
 
 struct CSSSyntaxComponent {
-    CSSSyntaxComponent(CSSSyntaxType type)
+    CSSSyntaxComponent(CSSSyntaxType type, const String& string, bool repeatable)
         : m_type(type)
+        , m_string(string)
+        , m_repeatable(repeatable)
     {
     }
 
     CSSSyntaxType m_type;
-    // TODO(timloh): This will need to support arbitrary idents and list types
+    String m_string; // Only used when m_type is CSSSyntaxType::Ident
+    bool m_repeatable;
 };
 
 class CSSSyntaxDescriptor {
 public:
     CSSSyntaxDescriptor(String syntax);
 
     const CSSValue* parse(CSSParserTokenRange) const;
     const CSSValue* parse(const String&) const;
     bool isValid() const { return !m_syntaxComponents.isEmpty(); }
     bool isTokenStream() const { return m_syntaxComponents.size() == 1 && m_syntaxComponents[0].m_type == CSSSyntaxType::TokenStream; }
 
 private:
     Vector<CSSSyntaxComponent> m_syntaxComponents;
 };
 
 } // namespace blink
 
 #endif // CSSSyntaxDescriptor_h